Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypttab: Trim trailing newlines #51594

Merged
merged 1 commit into from Feb 22, 2019
Merged

crypttab: Trim trailing newlines #51594

merged 1 commit into from Feb 22, 2019

Conversation

swegener
Copy link
Contributor

@swegener swegener commented Feb 1, 2019

SUMMARY

Having a comment or an empty line in /etc/crypttab results in an
additional empty line being added, because the newline that is part of
the line being read is getting re-injected in addition to the newline
used to concatenate the lines.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

crypttab

crypttab: Trim trailing newlines
d7f334b 
Having a comment or an empty line in /etc/crypttab results in an
additional empty line being added, because the newline that is part of
the line being read is getting re-injected in addition to the newline
used to concatenate the lines.

Signed-off-by: Sven Wegener <sven.wegener@inovex.de>
@ansibot
Copy link
Contributor

ansibot commented Feb 1, 2019

cc @groks
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Feb 1, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 9, 2019
@ansibot ansibot added the system System category label Feb 17, 2019
@gundalow
Copy link
Contributor

rebuild_merge

@swegener Thank you for this fix
@cabral404 @bmalynovytch Thank you for the review

@swegener If you'd like to see this fixed in Ansible 2.7 please raise a backport PR including changelog/fragment (after the Bot has merged this PR), see https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy

@gundalow gundalow self-assigned this Feb 22, 2019
@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 22, 2019
@gundalow gundalow merged commit a966662 into ansible:devel Feb 22, 2019
@swegener swegener deleted the crypttab-newlines branch March 14, 2019 11:00
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cabral404 cabral404 cabral404 approved these changes

@bmalynovytch bmalynovytch bmalynovytch approved these changes

Assignees

@gundalow gundalow

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swegener @ansibot @gundalow @cabral404 @bmalynovytch