Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise AnsibleConnectionError on winrm connnection errors #51744

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Raise AnsibleConnectionError on winrm connnection errors #51744

merged 3 commits into from
Feb 13, 2019

Commits on Feb 5, 2019

  1. Raise AnsibleConnectionError on winrm con errors 

    Currently all uncaught exceptions of the requests library that is used
in winrm will lead to an "Unexpected failure during module execution".

Instead of letting all exceptions bubble up we catch the connection
related errors (inkl. timeouts) and re-raise them as
AnsibleConnectionError so Ansible will mark the host as unreachable and
exit with the correct return code.

This is especially important for Zuul (https://zuul-ci.org) to
distinguish between failures and connection/host related errors.
    @westphahl
    westphahl committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    4e98af6 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Update lib/ansible/plugins/connection/winrm.py 

    Co-Authored-By: westphahl <westphahl@gmail.com>
    @samdoran @westphahl
    samdoran and westphahl committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    215bf25 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Add changelog fragment

    @westphahl
    westphahl committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    20afea7 View commit details
    Browse the repository at this point in the history