terraform: patch state 'planned' outputs and perform minor refactor

[banthaherder]

SUMMARY

Patches state == 'planned' command output and stdout by refactoring the plan/apply/destroy process to explicitly provide outputs. Minor refactoring was done to enable the command output without overriding the situation where state == 'present' but no plan file was specified.

In addition, I added the project_path when checking for the plan file. Before it would fail due to os.path.exists checking at the top level directory where the ansible-playbook command was ran and the module.run_command executing within the project directory. This created the need for the plan file to be duplicated at the top level directory (for checking purposes) and relative to your project_path.

Fixes #39689, addresses #43405

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

terraform

[ansibot]

cc @ryansb
click here for bot help

[gundalow]

@mohitkumarsharmaflux7 Hi, does this address #39689 which you raised
@Titerote does this address #43405 which you raised?

[gundalow]

@wrsuarez thank you for your feedback in #39689 (comment) Does this PR resolve the issue for you?

[ghost]

yes John

…

On Thu, Feb 21, 2019 at 7:39 PM John R Barker ***@***.***> wrote: @mohitkumarsharmaflux7 <https://github.com/mohitkumarsharmaflux7> Hi, does this address #39689 <#39689> which you raised @Titerote <https://github.com/Titerote> does this address #43405 <#43405> which you raised? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52004 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Agr8mEJne_vaKHL_DJfB1-ptrIT-PWBgks5vPqiRgaJpZM4ayuIT> .

-- *Mohit Kumar Sharma* *DevOps Engineer* *Flux7 Inc. <http://www.flux7.com>* *9166133475* *0141-4917785* Confidentiality Note: This e-mail and any attachments are confidential and may be protected by legal privilege. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.

-- Confidentiality Note: This e-mail and any attachments are confidential and may be protected by legal privilege. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.

[gundalow]

@banthaherder Thank you for this PR, your first I believe.
Could you please add a bug fix changelog/fragment https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy then I'll get this merged

@mohitkumarsharmaflux7 Thank you for the quick feedback!

[ghost]

Hi Guys, Is the issue resolved? or you are still working on it? Thanks

…

On Thu, Feb 21, 2019 at 7:54 PM John R Barker ***@***.***> wrote: @banthaherder <https://github.com/banthaherder> Thank you for this PR, your first I believe. Could you please add a bug fix changelog/fragment https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy then I'll get this merged @mohitkumarsharmaflux7 <https://github.com/mohitkumarsharmaflux7> Thank you for the quick feedback! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52004 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Agr8mINw2E6yrdKkG-Da-pik4eoCcUI7ks5vPqwZgaJpZM4ayuIT> .

-- *Mohit Kumar Sharma* *DevOps Engineer* *Flux7 Inc. <http://www.flux7.com>* *9166133475* *0141-4917785* Confidentiality Note: This e-mail and any attachments are confidential and may be protected by legal privilege. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.

-- Confidentiality Note: This e-mail and any attachments are confidential and may be protected by legal privilege. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.

[gundalow]

@mohitkumarsharmaflux7 Just waiting for a changelog to be added then I'll merge and backport

[ghost]

ok Thanks

…

On Fri, Feb 22, 2019 at 2:20 PM John R Barker ***@***.***> wrote: @mohitkumarsharmaflux7 <https://github.com/mohitkumarsharmaflux7> Just waiting for a changelog to be added then I'll merge and backport — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52004 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Agr8mF-1XGjXOkLwq8jD5G9D1U50RtKwks5vP69IgaJpZM4ayuIT> .

-- *Mohit Kumar Sharma* *DevOps Engineer* *Flux7 Inc. <http://www.flux7.com>* *9166133475* *0141-4917785* Confidentiality Note: This e-mail and any attachments are confidential and may be protected by legal privilege. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.

-- Confidentiality Note: This e-mail and any attachments are confidential and may be protected by legal privilege. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.

[banthaherder]

@gundalow I've added the changelog 👍

[gundalow]

Merged into devel for release in Ansible 2.8.
@banthaherder if you'd like this fixed in the next Ansible 2.7 release could you please raise a backport PR https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy Thanks in advance.