pids: case insensitive string comparison for process names

[CodeAbyss]

SUMMARY
"Fixes #52563"

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME
pids

ADDITIONAL INFORMATION
This fix will compare the user input process name and psutil returned process name with case insensitiveness. This will make the pids component more robust and usable.

[ansibot]

cc @saranyasridharan
click here for bot help

[CodeAbyss]

@Akasurde It seems the tests have again generated an "AttributeError" error. Can you kindly review the code? I am not able to find the bug. I have alreday put a check 'bool(name)' in place to avoid the call to "NoneType".lower().

[Akasurde]

@CodeAbyss Want to try this -

    return [p.info['pid'] for p in psutil.process_iter(attrs=['pid', 'name']) if p.info and p.info.get('name', None) and p.info['name'].lower() == name.lower()]

[ansibot]

@CodeAbyss This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

[Akasurde]

LGTM

[gundalow]

@CodeAbyss Can you please squash your commits to get rid of the Thanks to @Akasurde for suggestion :) change to Thanks to Akasurde for suggestion :) (without @)

The reason for this is GitHub will send him an email every time someone merges this

[CodeAbyss]

@gundalow I might sound naive, but I don't know how to squash the commits. I searched, but all of them are telling cmd line params for git. Can you guide me on how to do this on GitHub?

[Akasurde]

@CodeAbyss You need to following

1. You have 5 commits

* 755e839e4d - (HEAD -> patch-2, CodeAbyss/patch-2) Removed Whitespaces (5 days ago) <abyss> GitHub
* 9290e7b151 - Fixed "AttributeError" for 'NoneType'.lower() (5 days ago) <abyss> GitHub
* 5966f77172 - Fixed "AttributeError" for 'None' process name (6 days ago) <abyss> GitHub
* 5818be60cf - Fixed 'AttributeError' for lower() (6 days ago) <abyss> GitHub
* 549ff8bfb4 - case insensitive string comparison for process names (6 days ago) <abyss> GitHub

2. git rebase -i HEAD~5 - This will rebase your branch (squashing)

pick 549ff8bfb4 case insensitive string comparison for process names
squash 5818be60cf Fixed 'AttributeError' for lower()
squash 5966f77172 Fixed "AttributeError" for 'None' process name
squash 9290e7b151 Fixed "AttributeError" for 'NoneType'.lower()
squash 755e839e4d Removed Whitespaces

3. Save your changes and amend commit message where it says name in commit message.

4. git push origin patch-2 --force

You can read about interactive rebase here - https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history and https://git-scm.com/book/en/v2/Git-Branching-Rebasing

[Akasurde]

@CodeAbyss Any news ? Let me know if you want me to take over this PR and get it merged. Thanks.

[CodeAbyss]

@Akasurde I have followed the steps as per your instructions & below are the details. Kindly have a look::

git log
commit ef523e10a86281211b602a896d58c4a4b3a37d53 (HEAD -> devel)
Author: abyss
Date:   Tue Feb 19 16:40:27 2019 +0530
    case insensitive string comparison for process names
    Fixed 'AttributeError' for lower()
    Fixed "AttributeError: 'NoneType' object has no attribute 'lower'" error for "Empty" or None strings passed as process name.
    Fixed "AttributeError" for 'None' process name
    Fixed "AttributeError" for object 'NoneType' while calling lower() on the returned process info from psutil's process_iter.
    Thanks to Akasurde for suggestion :)
    Fixed "AttributeError" for 'NoneType'.lower()
    Added check on p.info and p.info['name'] to check if they are Empty or None, and then calling lower() on them.
    The older commit message contained the mentions, so commiting new with changed commit message.
    Removed Whitespaces
    Removed whitespaces. Added them earlier to amend the previous commit message.

git push origin patch-2 --force
Everything up-to-date

git push
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 2 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (7/7), 953 bytes | 476.00 KiB/s, done.
Total 7 (delta 5), reused 1 (delta 0)
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
To https://github.com/CodeAbyss/ansible.git
   57d85031d7..ef523e10a8  devel -> devel

Is that it or do I have to create a new PR?