Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ec2 regression when assigning a private IP without a public IP #52579

Merged
merged 1 commit into from
Mar 4, 2019
Merged

fix ec2 regression when assigning a private IP without a public IP #52579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/ec2_fix_assigning_private_without_public_ip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
bugfixes:
- ec2 - if the private_ip has been provided for the new network interface it shouldn't also be added to top level
parameters for run_instances()
2 changes: 1 addition & 1 deletion lib/ansible/modules/cloud/amazon/ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ def create_instances(module, ec2, vpc, override_count=None):

# check to see if we're using spot pricing first before starting instances
if not spot_price:
if assign_public_ip and private_ip:
if assign_public_ip is not None and private_ip:
params.update(
dict(
min_count=count_remaining,
Expand Down