Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Refactor guest inventory plugin #52642

Merged
merged 2 commits into from Feb 22, 2019
Merged

VMware: Refactor guest inventory plugin #52642

merged 2 commits into from Feb 22, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Feb 20, 2019 •
edited

SUMMARY

Fixes: #52381

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/inventory/vmware_vm_inventory.py
test/integration/targets/inventory_vmware_vm_inventory/runme.sh

This was referenced Feb 20, 2019
Closed
Closed
@Akasurde
Copy link
Member Author

@s-hertel As per #50645 (comment) I am moved code in vmware_vm_inventory. Once this is merged I will refactor #50645.

Could you please review this and let me know ? Thanks

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 20, 2019
@Akasurde
VMware: Refactor guest inventory plugin
61f05db 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 20, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 21, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 21, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Feb 21, 2019
s-hertel
s-hertel reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if there was a test that the cache could be used to populate inventory rather than just that the cache is being set, but that could be added later. LGTM.

lib/ansible/plugins/inventory/vmware_vm_inventory.py Outdated Show resolved Hide resolved
@Akasurde
Review comments
799c158 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde merged commit e41b98f into ansible:devel Feb 22, 2019
@Akasurde Akasurde deleted the vmware_vm_refactor branch February 22, 2019 04:26
@Akasurde
Copy link
Member Author

@bcoca @gundalow @s-hertel Thanks for the review.

@Akasurde Akasurde mentioned this pull request Feb 22, 2019
Merged
@Akasurde Akasurde mentioned this pull request Feb 27, 2019
Closed
@Akasurde Akasurde mentioned this pull request Mar 8, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca left review comments

@gundalow gundalow gundalow left review comments

@s-hertel s-hertel s-hertel left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMware: ansible-inventory "cannot represent an object" when adding --yaml flag
5 participants
@Akasurde @bcoca @gundalow @s-hertel @ansibot