Onesixtyone inventory plugin (Fixes #41443) #53036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test The test The test The test The test The test The test The test The test |
ansibot
added
affects_2.8
|
The test The test The test The test The test The test The test The test The test |
Akasurde
requested changes
Feb 27, 2019
webknjaz
reviewed
Feb 27, 2019
webknjaz
reviewed
Feb 27, 2019
webknjaz
reviewed
Feb 27, 2019
webknjaz
reviewed
Feb 27, 2019
|
The test The test The test The test The test The test The test The test |
|
The test The test The test The test The test The test The test |
bcoca
requested changes
Feb 27, 2019
|
The test The test The test The test The test The test The test |
victorock
force-pushed
the
onesixtyone-inventory-plugin
branch
from
d90201d
to
3d577f0
Compare
|
The test The test The test The test The test The test The test |
Akasurde
reviewed
Feb 28, 2019
Akasurde
reviewed
Feb 28, 2019
bcoca
requested changes
Mar 5, 2019
webknjaz
reviewed
Mar 6, 2019
webknjaz
reviewed
Mar 6, 2019
webknjaz
reviewed
Mar 6, 2019
webknjaz
reviewed
Mar 6, 2019
webknjaz
reviewed
Mar 6, 2019
webknjaz
reviewed
Mar 6, 2019
- organize errors/exceptions - add trailing ',' - remove '^' from regex
victorock
force-pushed
the
onesixtyone-inventory-plugin
branch
from
bacb574
to
80b8e51
Compare
ansibot
removed
stale_ci
webknjaz
requested review from
Akasurde and
bcoca
and removed request for
Akasurde
webknjaz
reviewed
May 16, 2019
| DOCUMENTATION = ''' | ||
| name: onesixtyone | ||
| plugin_type: inventory | ||
| version_added: "2.8" |
There was a problem hiding this comment.
Suggested change
| version_added: "2.8" | |
| version_added: "2.9" |
webknjaz
reviewed
May 16, 2019
| try: | ||
| from netaddr import IPSet | ||
| HAS_NETADDR = True | ||
| except Exception: |
webknjaz
reviewed
May 16, 2019
| NAME = 'onesixtyone' | ||
|
|
||
| def __init__(self): | ||
| super(InventoryModule, self).__init__() |
There was a problem hiding this comment.
Empty proxy-init doesn't make sense and should be removed.
webknjaz
reviewed
May 16, 2019
| # Find the onesixtyone binary | ||
| try: | ||
| self._onesixtyone = get_bin_path(self.NAME, True) | ||
| except Exception: |
There was a problem hiding this comment.
Please, use actual exception which may happen. Wholesale catch-all is bad.
webknjaz
reviewed
May 16, 2019
| } | ||
| platforms.update(self.get_option('platform')) | ||
|
|
||
| for platform, rule in platforms.items(): |
There was a problem hiding this comment.
Suggested change
| for platform, rule in platforms.items(): | |
| return next(platform for platform, rule in platforms.items() if rule.match(text), 'unknown') |
webknjaz
reviewed
May 16, 2019
| communities_tempfile.flush() | ||
|
|
||
| # add command-line option -c | ||
| cmd.append('-c') |
There was a problem hiding this comment.
It'd be probably better readable with
Suggested change
| cmd.append('-c') | |
| cmd.extend(('-c', communities_tempfile.name)) |
instead
webknjaz
reviewed
May 16, 2019
|
|
||
| # execute | ||
| try: | ||
| self.display.vvv("running command: {cmd}".format(cmd=cmd_string)) |
There was a problem hiding this comment.
This should go outside of try block
webknjaz
reviewed
May 16, 2019
| matches = None | ||
|
|
||
| for line in cmd_output.splitlines(): | ||
| self.display.vvv("parsing output line: {line}".format(line=line)) |
There was a problem hiding this comment.
this should probably go to the debug level
webknjaz
reviewed
May 16, 2019
| if host.endswith('.in-addr.arpa'): | ||
| obj.display.vvv("Reverse DNS for host {host} contains 'in-addr.arpa', using {ansible_host}`".format(host=host, ansible_host=ansible_host)) | ||
| host = ansible_host | ||
| except Exception: |
ansibot
added
stale_ci
ansibot
added
community_review
ansibot
added
needs_revision
|
Hi @victorock, Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.general |
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add inventory plugin for onesixtyone, which is lightweight and fast in discovery of devices running SNMP.
Fixes #41443
ISSUE TYPE
COMPONENT NAME
onesixtyone
ADDITIONAL INFORMATION