-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run integration tests for OS'es older than Windows 2016 #53057
Conversation
The tests cover this usually based on capabilities, which is our preferred way of doing it.
This means that if our targets would be upgraded to PowerShell 5 the tests would run. The fact that our CI reports no errors means this is working fine as-is. |
@dagwieers, Can you discuss that case with @jborean93, please? |
@it-praktyk Ok, I wasn't aware. Re-opened :-) |
Looks good, thanks for doing this. @dagwieers this means CI won't have to wait until the hosts hosts are ready before effectively skipping the test. It saves us both time and money as they don't need to run on them. We still need to keep the conditionals in the test in case we are running it locally though. |
SUMMARY
The pull request disables running of integration test on Windows Server 2008, 2008R2, 2012, 2012 R2 due that PowerShell >= 5.0 is required to run tests.
ISSUE TYPE
COMPONENT NAME
win_dsc
win_firewall
ADDITIONAL INFORMATION
It should be backported to versions 2.5-2.7 too.