Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Update example connection details when using dvswitch #53084

Merged
merged 1 commit into from Mar 11, 2019
Merged

VMware: Update example connection details when using dvswitch #53084

merged 1 commit into from Mar 11, 2019

Conversation

UnknownGnome
Copy link
Contributor

SUMMARY

Update examples to specify vcenter connection details when using dvswitch.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vmware_vmkernel.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @Akasurde @Tomorrow9 @ckotte @dav1x @lparkes @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

@UnknownGnome, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Feb 27, 2019
@Akasurde Akasurde changed the title Update example connection details when using dvswitch VMware: Update example connection details when using dvswitch Mar 4, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 4, 2019
@alongchamps
Copy link
Contributor

LGTM

@adarobin
Copy link
Contributor

adarobin commented Mar 4, 2019

@UnknownGnome is there a reason you haven't updated all of the examples? I'm guessing that you're trying to highlight one of the things called out in the notes - "You can only create the VMKernel adapter on a vDS if authenticated to vCenter and not if authenticated to ESXi."

@UnknownGnome
Copy link
Contributor Author

@adarobin Yes. The other examples work with esxi credentials because they are updating standard switches. The dvswitch examples do not work unless using vCenter credentials.
After I submitted this pull request, I saw that ckotte mentioned in his pull request that he needed to update the examples.
First pull request - forgive me if it's done improperly.

adarobin
adarobin approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@adarobin adarobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acozine
Copy link
Contributor

acozine commented Mar 11, 2019

Thanks @UnknownGnome for contributing your experience back to the Ansible community.

@acozine acozine merged commit b03b951 into ansible:devel Mar 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adarobin adarobin adarobin approved these changes

@alongchamps alongchamps alongchamps approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@UnknownGnome @ansibot @alongchamps @adarobin @acozine @Akasurde