Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional DevTest Lab modules #53091

Merged
merged 24 commits into from Mar 20, 2019
Merged

Additional DevTest Lab modules #53091

merged 24 commits into from Mar 20, 2019

Conversation

zikalino
Copy link
Contributor

SUMMARY

Adding additional DevTest Lab modules for frequent scenarios in addition to modules we already have

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_devtestlabcustomimage
azure_rm_devtestlabglobalschedule
azure_rm_devtestlabpolicy
azure_rm_devtestlabenvironment

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabscustomimage.py:244:51: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabscustomimage.py:245:51: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabscustomimage.py:313:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsenvironment.py:198:9: E303 too many blank lines (2)
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsenvironment.py:251:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsglobalschedule.py:236:54: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsglobalschedule.py:237:54: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsglobalschedule.py:305:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_devtestlabspolicy.py:278:17: E123 closing bracket does not match indentation of opening bracket's line

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

@zikalino this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 azure ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 28, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy.py:208:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabpolicy.py:209:45: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 28, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Feb 28, 2019
Closed
@zikalino zikalino force-pushed the adding-dtl-additional-functionality branch from dd1708c to b40746a Compare March 1, 2019 00:06
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2019

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabsvirtualmachineschedule.py:256:63: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsvirtualmachineschedule.py:257:63: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsvirtualmachineschedule.py:325:17: E123 closing bracket does not match indentation of opening bracket's line

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2019

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabsvirtualmachineschedule.py:256:63: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsvirtualmachineschedule.py:257:63: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabsvirtualmachineschedule.py:325:17: E123 closing bracket does not match indentation of opening bracket's line

click here for bot help

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 1, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 3, 2019

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:263:73: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:264:73: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:265:73: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:266:73: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 3, 2019

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:194:53: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:195:53: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:196:53: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_devtestlabenvironment.py:197:53: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 3, 2019
@zikalino zikalino force-pushed the adding-dtl-additional-functionality branch from 18cf794 to e655990 Compare March 18, 2019 10:43
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 18, 2019
@nitzmahone nitzmahone merged commit c431d18 into ansible:devel Mar 20, 2019
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Mar 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zikalino @ansibot @Fred-sun @nitzmahone @mkrizek