Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_user: fails to remove usernames with embedded '\' #53149

Merged
merged 1 commit into from
Mar 7, 2019
Merged

nxos_user: fails to remove usernames with embedded '\' #53149

merged 1 commit into from
Mar 7, 2019

Conversation

chrisvanheuveln
Copy link
Contributor

SUMMARY

When purge: yes is set in a playbook, nxos_user should remove all non-admin users. Any usernames that have embedded \ chars are not being removed because the \ needs to be escaped.

Example: username ucs-DOMAIN\x password 0 foo

Found by common/sanity test.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_user

@chrisvanheuveln
nxos_user: fails to remove usernames with embedded '\'
dfdd485 
Example: username ucs-DOMAIN\\x password 0 foo

Found by `common/sanity` test.
@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Feb 28, 2019
@trishnaguha trishnaguha merged commit fd6e45b into ansible:devel Mar 7, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2019
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 1, 2019
@chrisvanheuveln @trishnaguha
nxos_user: fails to remove usernames with embedded '\' (ansible#53149)
27e25f9 
Example: username ucs-DOMAIN\\x password 0 foo

Found by `common/sanity` test.

(cherry picked from commit fd6e45b)
abadger pushed a commit that referenced this pull request Apr 4, 2019
@chrisvanheuveln @abadger
nxos_user: fails to remove usernames with embedded '\' (#53149)
7dcfa2c 
Example: username ucs-DOMAIN\\x password 0 foo

Found by `common/sanity` test.

(cherry picked from commit fd6e45b)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisvanheuveln @ansibot @trishnaguha @sivel