Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove state: present #53434

Merged
merged 1 commit into from
Mar 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
name: testacr1
location: eastus
resource_group: myResourceGroup
state: present
admin_user_enabled: true
sku: Premium
tags:
Expand Down
4 changes: 0 additions & 4 deletions lib/ansible/modules/cloud/azure/azure_rm_deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
# Create or update a template deployment based on uris using parameter and template links
- name: Create Azure Deploy
azure_rm_deployment:
state: present
resource_group_name: dev-ops-cle
template_link: 'https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/101-vm-simple-linux/azuredeploy.json'
parameters_link: 'https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/101-vm-simple-linux/azuredeploy.parameters.json'
Expand All @@ -128,7 +127,6 @@

- name: Create Azure Deploy
azure_rm_deployment:
state: present
subscription_id: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
resource_group_name: dev-ops-cle
parameters:
Expand Down Expand Up @@ -169,7 +167,6 @@
# Deploy an Azure WebApp running a hello world'ish node app
- name: Create Azure WebApp Deployment at http://devopscleweb.azurewebsites.net/hello.js
azure_rm_deployment:
state: present
subscription_id: cbbdaed0-fea9-4693-bf0c-d446ac93c030
resource_group_name: dev-ops-cle-webapp
parameters:
Expand All @@ -188,7 +185,6 @@
# Create or update a template deployment based on an inline template and parameters
- name: Create Azure Deploy
azure_rm_deployment:
state: present
subscription_id: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
resource_group_name: dev-ops-cle

Expand Down
3 changes: 0 additions & 3 deletions lib/ansible/modules/cloud/azure/azure_rm_dnsrecordset.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
relative_name: www
zone_name: testing.com
record_type: A
state: present
records:
- entry: 192.168.100.101
- entry: 192.168.100.102
Expand All @@ -125,7 +124,6 @@
azure_rm_dnsrecordset:
resource_group: myResourceGroup
zone_name: testing.com
state: present
relative_name: "{{ item.name }}"
record_type: "{{ item.type }}"
records: "{{ item.records }}"
Expand All @@ -141,7 +139,6 @@
zone_name: testing.com
time_to_live: 7200
record_type: SRV
state: present
records:
- entry: sip.testing.com
preference: 10
Expand Down
1 change: 0 additions & 1 deletion lib/ansible/modules/cloud/azure/azure_rm_dnszone.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
azure_rm_dnszone:
resource_group: myResourceGroup
name: example.com
state: present

- name: Delete a DNS zone
azure_rm_dnszone:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
name: "acr{{ resource_group | hash('md5') | truncate(7, True, '') }}"
resource_group: "{{ resource_group }}"
location: eastus2
state: present
admin_user_enabled: true
sku: Premium
tags:
Expand Down Expand Up @@ -42,7 +41,6 @@
name: "acr{{ resource_group | hash('md5') | truncate(7, True, '') }}sec"
resource_group: "{{ resource_group }}"
location: eastus2
state: present
admin_user_enabled: false
sku: Premium
tags:
Expand Down
2 changes: 0 additions & 2 deletions test/integration/targets/azure_rm_dnszone/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@
zone_name: "{{ domain_name }}.com"
time_to_live: 7200
record_type: SRV
state: present
records:
- entry: sip.{{ domain_name }}.com
priority: 20
Expand All @@ -241,7 +240,6 @@
relative_name: "_txt.{{ domain_name }}.com"
zone_name: "{{ domain_name }}.com"
record_type: TXT
state: present
records:
- entry: "v=spf1 a -all"
- entry: "foo"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
resource_group: "{{ resource_group }}"
name: "invalid_char$"
disk_size_gb: 1
state: present
register: output
ignore_errors: yes
check_mode: no
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
azure_rm_storageaccount:
resource_group: "{{ resource_group }}"
name: "invalid_char$"
state: present
register: invalid_name
ignore_errors: yes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
resource_group: "{{ resource_group }}"
name: "{{ storage_account }}"
account_type: Standard_LRS
state: present

- name: Create container
azure_rm_storageblob:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@
azure_rm_virtualmachine:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
image:
offer: UbuntuServer
register: fail_invalid_image_dict
Expand All @@ -423,7 +422,6 @@
azure_rm_virtualmachine:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
image:
- testing
register: fail_invalid_image_type
Expand All @@ -433,7 +431,6 @@
azure_rm_virtualmachine:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
image: invalid-image
register: fail_missing_custom_image
failed_when: fail_missing_custom_image.msg != "Error could not find image with name invalid-image"
Expand All @@ -442,7 +439,6 @@
azure_rm_virtualmachine:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
image:
name: invalid-image
register: fail_missing_custom_image_dict
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,6 @@
azure_rm_virtualmachine_scaleset:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
vm_size: Standard_B1s
image:
offer: UbuntuServer
Expand All @@ -591,7 +590,6 @@
azure_rm_virtualmachine_scaleset:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
vm_size: Standard_B1s
image:
- testing
Expand All @@ -602,7 +600,6 @@
azure_rm_virtualmachine_scaleset:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
vm_size: Standard_B1s
image: invalid-image
register: fail_missing_custom_image
Expand All @@ -612,7 +609,6 @@
azure_rm_virtualmachine_scaleset:
resource_group: "{{ resource_group }}"
name: testvm002
state: present
vm_size: Standard_B1s
image:
name: invalid-image
Expand Down