Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_ospf_vrf: sanity.yaml test: fix timer_throttle_lsa_hold #53561

Merged
merged 1 commit into from Mar 11, 2019
Merged

nxos_ospf_vrf: sanity.yaml test: fix timer_throttle_lsa_hold #53561

merged 1 commit into from Mar 11, 2019

Conversation

chrisvanheuveln
Copy link
Contributor

SUMMARY

  • The test was setting lsa max value to 2222 but the default lsa hold value is 5000.

  • hold must be less than max or else the device raises a clierror, so I just added a lower non-default hold value to satisfy the cli.

  • Also added an initial cleanup for the test.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_ospf_vrf

@chrisvanheuveln
nxos_ospf_vrf: sanity.yaml test: fix timer_throttle_lsa_hold
f0a6418 
* The test was setting `lsa max` value to 2222 but the default `lsa hold` value is 5000.

* `hold` must be less than `max` or else the device raises a clierror, so I just added a lower non-default `hold` value to satisfy the cli.
@ansibot
Copy link
Contributor

ansibot commented Mar 8, 2019

cc @GGabriele @mikewiebe @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 8, 2019
@trishnaguha trishnaguha merged commit c1e9f59 into ansible:devel Mar 11, 2019
@trishnaguha trishnaguha self-assigned this Mar 11, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2019
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 1, 2019
@chrisvanheuveln @trishnaguha
nxos_ospf_vrf: sanity.yaml test: fix timer_throttle_lsa_hold (ansible…
c1113e3 
…#53561)

* The test was setting `lsa max` value to 2222 but the default `lsa hold` value is 5000.

* `hold` must be less than `max` or else the device raises a clierror, so I just added a lower non-default `hold` value to satisfy the cli.

(cherry picked from commit c1e9f59)
abadger pushed a commit that referenced this pull request Apr 4, 2019
@chrisvanheuveln @abadger
nxos_ospf_vrf: sanity.yaml test: fix timer_throttle_lsa_hold (#53561)
1f5d412 
* The test was setting `lsa max` value to 2222 but the default `lsa hold` value is 5000.

* `hold` must be less than `max` or else the device raises a clierror, so I just added a lower non-default `hold` value to satisfy the cli.

(cherry picked from commit c1e9f59)
@chrisvanheuveln chrisvanheuveln deleted the devel-nxos_ospf_vrf branch April 18, 2019 18:01
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisvanheuveln @ansibot @trishnaguha @sivel