Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lenovo cnos system module #53764

Merged
merged 8 commits into from Mar 20, 2019
Merged

Lenovo cnos system module #53764

merged 8 commits into from Mar 20, 2019
+965 −2

Conversation

amuraleedhar
Copy link
Contributor

@amuraleedhar amuraleedhar commented Mar 13, 2019 •
edited

SUMMARY

Introducing new module cnos_system to facilitate system configurations on Lenovo cnos devices.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/network/cnos/cnos_system.py
test/integration/targets/cnos_system/defaults/main.yaml
test/integration/targets/cnos_system/tasks/cli.yaml
test/integration/targets/cnos_system/tasks/main.yaml
test/integration/targets/cnos_system/tests/cli/net_system.yaml
test/integration/targets/cnos_system/tests/cli/set_domain_list.yaml
test/integration/targets/cnos_system/tests/cli/set_domain_name.yaml
test/integration/targets/cnos_system/tests/cli/set_name_servers.yaml
test/integration/targets/cnos_system/tests/common/sanity.yaml
test/integration/targets/cnos_system/tests/common/set_hostname.yaml
test/units/modules/network/cnos/fixtures/cnos_system_config.cfg
test/units/modules/network/cnos/test_cnos_system.py
test/integration/targets/cnos_linkagg/cnos_linkagg_sample_hosts
test/integration/targets/cnos_system/aliases
test/integration/targets/cnos_system/cnos_system_sample_hosts

ANSIBLE VERSION

ansible 2.8.0.dev0 (devel e2b9c36) last updated 2018/10/12 13:58:41 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

Please dont start review of this PR immediately. A lot more need to be done. This is done as placeholder for 2.8

@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2019

@amuraleedhar this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

lib/ansible/modules/network/cnos/cnos_system.py:163:78: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/cnos/cnos_system.py:277:31: bad-whitespace No space allowed before bracket def parse_domain_search(config ):                                ^
lib/ansible/modules/network/cnos/cnos_system.py:389:0: trailing-newlines Trailing newlines
test/units/modules/network/cnos/test_cnos_system.py:104:0: missing-final-newline Final newline missing
test/units/modules/network/cnos/test_cnos_system.py:104:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/network/cnos/cnos_system.py:163:79: W291 trailing whitespace
lib/ansible/modules/network/cnos/cnos_system.py:277:31: E202 whitespace before ')'
lib/ansible/modules/network/cnos/cnos_system.py:389:1: W391 blank line at end of file
test/units/modules/network/cnos/test_cnos_system.py:101:5: E303 too many blank lines (2)
test/units/modules/network/cnos/test_cnos_system.py:104:61: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cnos/cnos_system.py:388:0: E109 Next to last line should be: if __name__ == "__main__":

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/cnos_system/tasks/cli.yaml:34:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2019

cc @NilashishC @Qalthos @auraleedhar @dkasberg @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Mar 18, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 18, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 18, 2019
@amuraleedhar amuraleedhar mentioned this pull request Mar 18, 2019
Closed
@Qalthos Qalthos merged commit 7a24ecd into ansible:devel Mar 20, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 20, 2019
@amuraleedhar amuraleedhar deleted the lenovo-cnos-system branch April 8, 2019 04:10
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amuraleedhar @ansibot @sivel @Qalthos