Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenovo cnos system module #53764

Merged
merged 8 commits into from Mar 20, 2019

Conversation

Projects
None yet
4 participants
@amuraleedhar
Copy link
Contributor

amuraleedhar commented Mar 13, 2019

SUMMARY

Introducing new module cnos_system to facilitate system configurations on Lenovo cnos devices.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/network/cnos/cnos_system.py
test/integration/targets/cnos_system/defaults/main.yaml
test/integration/targets/cnos_system/tasks/cli.yaml
test/integration/targets/cnos_system/tasks/main.yaml
test/integration/targets/cnos_system/tests/cli/net_system.yaml
test/integration/targets/cnos_system/tests/cli/set_domain_list.yaml
test/integration/targets/cnos_system/tests/cli/set_domain_name.yaml
test/integration/targets/cnos_system/tests/cli/set_name_servers.yaml
test/integration/targets/cnos_system/tests/common/sanity.yaml
test/integration/targets/cnos_system/tests/common/set_hostname.yaml
test/units/modules/network/cnos/fixtures/cnos_system_config.cfg
test/units/modules/network/cnos/test_cnos_system.py
test/integration/targets/cnos_linkagg/cnos_linkagg_sample_hosts
test/integration/targets/cnos_system/aliases
test/integration/targets/cnos_system/cnos_system_sample_hosts

ANSIBLE VERSION

ansible 2.8.0.dev0 (devel e2b9c36) last updated 2018/10/12 13:58:41 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

Please dont start review of this PR immediately. A lot more need to be done. This is done as placeholder for 2.8

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

@amuraleedhar this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@amuraleedhar amuraleedhar force-pushed the amuraleedhar:lenovo-cnos-system branch from 4450997 to a554eaa Mar 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

lib/ansible/modules/network/cnos/cnos_system.py:163:78: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/cnos/cnos_system.py:277:31: bad-whitespace No space allowed before bracket def parse_domain_search(config ):                                ^
lib/ansible/modules/network/cnos/cnos_system.py:389:0: trailing-newlines Trailing newlines
test/units/modules/network/cnos/test_cnos_system.py:104:0: missing-final-newline Final newline missing
test/units/modules/network/cnos/test_cnos_system.py:104:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/network/cnos/cnos_system.py:163:79: W291 trailing whitespace
lib/ansible/modules/network/cnos/cnos_system.py:277:31: E202 whitespace before ')'
lib/ansible/modules/network/cnos/cnos_system.py:389:1: W391 blank line at end of file
test/units/modules/network/cnos/test_cnos_system.py:101:5: E303 too many blank lines (2)
test/units/modules/network/cnos/test_cnos_system.py:104:61: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cnos/cnos_system.py:388:0: E109 Next to last line should be: if __name__ == "__main__":

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/cnos_system/tasks/cli.yaml:34:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot

This comment has been minimized.

amuraleedhar added some commits Mar 18, 2019

@ansibot ansibot removed the ci_verified label Mar 18, 2019

@ansibot ansibot added core_review and removed needs_revision labels Mar 18, 2019

@Qalthos Qalthos merged commit 7a24ecd into ansible:devel Mar 20, 2019

1 check passed

Shippable Run 114380 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.