Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax highlighting #53945

Merged
merged 2 commits into from Mar 21, 2019
Merged

Fix syntax highlighting #53945

merged 2 commits into from Mar 21, 2019

Conversation

vlad-ro
Copy link
Contributor

@vlad-ro vlad-ro commented Mar 18, 2019 •
edited

SUMMARY

This fixes broken syntax highlighting for \' inside a single quoted string.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_ssm lookup plugin

@vlad-ro
Fix syntax highlighting
a890e48 
This fixes broken syntax highlighting for \' inside a single quoted string.
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. and removed new_contributor This PR is the first contribution by a new community member. labels Mar 18, 2019
@acozine
Copy link
Contributor

acozine commented Mar 20, 2019

Thanks for catching that @vlad-ro! We're looking at a couple of alternatives that would avoid the apostrophe-looks-like-a-single-quote problem, so we may add some commits to this PR.

@acozine
Copy link
Contributor

acozine commented Mar 20, 2019

@vlad-ro could you accept @gundalow's suggestion? We tested it and the syntax highlighting is fixed this way as well.

@gundalow @vlad-ro
Update lib/ansible/plugins/lookup/aws_ssm.py
069d9df 
Co-Authored-By: vlad-ro <vlad-ro@users.noreply.github.com>
@gundalow
Copy link
Contributor

@vlad-ro Thank you for this.
CI failures are unrelated, so merging

@gundalow gundalow merged commit e216aaf into ansible:devel Mar 21, 2019
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Mar 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vlad-ro @acozine @gundalow @mkrizek @ansibot