Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGIP: New Module bigip_device_ha_group #53967

Merged
merged 1 commit into from Mar 19, 2019
Merged

BIGIP: New Module bigip_device_ha_group #53967

merged 1 commit into from Mar 19, 2019

Conversation

wojtek0806
Copy link
Contributor

SUMMARY

Adds new module to manage and create ha groups

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

bigip_device_ha_group

@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2019

cc @caphrim007
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 18, 2019
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Mar 19, 2019
caphrim007
caphrim007 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@caphrim007 caphrim007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

Suggest that the submitter consider changing the dates in the file from 2018 to 2019, and that they consider a strategy for merging the majority of duplicated code in the pools and trunks properties in a future PR. Not a show-stopper though.

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 19, 2019
@caphrim007 caphrim007 merged commit 2b00cb5 into ansible:devel Mar 19, 2019
@wojtek0806 wojtek0806 deleted the newmodule.bigip_devce_ha_group branch March 28, 2019 16:29
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caphrim007 caphrim007 caphrim007 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wojtek0806 @ansibot @caphrim007