Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos install os timeout regular expression #53994

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix nxos install os timeout regular expression #53994

merged 1 commit into from
Mar 20, 2019

Conversation

mikewiebe
Copy link
Contributor

SUMMARY

This PR fixes the regular expression used by nxos_install_os to capture a timeout event.

In the latest devel branch the message returned by module_utils/nxos.py is different then what was returned by earlier versions.

This fix makes the regexp a bit more lenient.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_install_os

@mikewiebe mikewiebe changed the title Rel280/fix nxos install os fix nxos install os timeout regular expression Mar 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2019

cc @GGabriele @chrisvanheuveln @jedelman8 @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Mar 18, 2019
@trishnaguha trishnaguha self-assigned this Mar 19, 2019
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Mar 19, 2019
@chrisvanheuveln
Copy link
Contributor

👍

@trishnaguha trishnaguha merged commit 07212c3 into ansible:devel Mar 20, 2019
@trishnaguha trishnaguha added this to Needs Triage in Networking via automation Mar 20, 2019
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 1, 2019
@mikewiebe @trishnaguha
Fix regular expression for timeout (ansible#53994)
f8a1867 
(cherry picked from commit 07212c3)
abadger pushed a commit that referenced this pull request Apr 4, 2019
@mikewiebe @abadger
Fix regular expression for timeout (#53994)
a8f5619 
(cherry picked from commit 07212c3)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
Networking
  
Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikewiebe @ansibot @chrisvanheuveln @trishnaguha