Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible supports ZTE's Operating System os-release #54160

Open
wants to merge 3 commits into
base: devel
from

Conversation

@Sasocai
Copy link

commented Mar 21, 2019

Signed-off-by: CaiJiYan cai.jiyan@zte.com.cn

SUMMARY
adds support for NewStart

ISSUE TYPE
Feature Pull Request

COMPONENT NAME
lib/ansible/module_utils/facts/system/distribution.py

CaiJiYan
ansible supports ZTE's Operating System os-release
Signed-off-by: CaiJiYan <cai.jiyan@zte.com.cn>
@gundalow
Copy link
Contributor

left a comment

Hi,
Thanks for adding support for ZTE to Ansibe's facts systems.

We have some unit tests for this in test/units/module_utils/test_distribution_version.py

You can run them locally by running the following command from your checkout
bin/ansible-test units -v --docker default test/units/module_utils/test_distribution_version.py

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/facts/system/distribution.py:260:5: E303 too many blank lines (2)

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Mar 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/facts/system/distribution.py:260:5: E303 too many blank lines (2)

click here for bot help

@ansibot ansibot added the ci_verified label Mar 22, 2019

@Akasurde Akasurde self-assigned this Mar 22, 2019

Update distribution.py
del 259 blank line

@sivel sivel requested a review from samdoran Apr 2, 2019

@sivel sivel removed the needs_triage label Apr 2, 2019

@ansibot ansibot added the stale_ci label Apr 2, 2019

@samdoran
Copy link
Member

left a comment

We also need an entry in OS_FAMILY_MAP in the Distribution class. Please add unit tests with example data from /etc/cgsl-release. Look at test/units/module_utils/test_distribution_version.py for examples. You can run hacking/tests/gen_distribution_version_testcase.py to generate test data.

@ansibot ansibot added needs_revision and removed core_review labels Apr 3, 2019

Update distribution.py
entry in OS_FAMILY_MAP in the Distribution class add 'NewStart',
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.