Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI: Ensure we use native strings for signature #55163

Merged
merged 2 commits into from Apr 16, 2019
Merged

ACI: Ensure we use native strings for signature #55163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
820d46f
ACI: Ensure we use native strings for signature
dagwieers Apr 11, 2019
7693979
Add changelog fragment
dagwieers Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/55150-native-strings-for-signature-auth.yaml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- aci modules - Ensure we use native strings for signature
4 changes: 2 additions & 2 deletions lib/ansible/module_utils/network/aci/aci.py
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@

from ansible.module_utils.parsing.convert_bool import boolean
from ansible.module_utils.urls import fetch_url
from ansible.module_utils._text import to_bytes
from ansible.module_utils._text import to_bytes, to_native

# Optional, only used for APIC signature-based authentication
try:
Expand Down Expand Up @@ -279,7 +279,7 @@ def cert_auth(self, path=None, payload='', method=None):
self.headers['Cookie'] = 'APIC-Certificate-Algorithm=v1.0; ' +\
'APIC-Certificate-DN=%s; ' % sig_dn +\
'APIC-Certificate-Fingerprint=fingerprint; ' +\
'APIC-Request-Signature=%s' % sig_signature
'APIC-Request-Signature=%s' % to_native(sig_signature)

def response_json(self, rawoutput):
''' Handle APIC JSON response output '''
Expand Down