Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for removing subscripion_id from resource facts #55203

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@zikalino
Copy link
Contributor

commented Apr 12, 2019

SUMMARY

This is fixing following issue:

#55047

subscription_id is being removed from all returned resource urls when parameter subscription_id is specified.

in 99.99% of cases subscription_id is returned & displayed in plain text anyway, as subscription_id parameter is not commonly used.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

all

ADDITIONAL INFORMATION

@zikalino zikalino requested review from yungezz and nitzmahone Apr 12, 2019

@ansibot

This comment has been minimized.

@yungezz

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

HI @nitzmahone could you pls look at this PR? although we found that subscription_id no_log=True will cause subscrption_id in outputed resource_id been masked as *, we still don't know why.

@zikalino zikalino merged commit 48cb681 into ansible:devel Apr 18, 2019

1 check passed

Shippable Run 119100 status is SUCCESS.
Details

@zikalino zikalino deleted the VSChina:fix-for-removing-subscription-id branch Apr 18, 2019

@yungezz

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@zikalino could you pls backport this fix?

ruimoreira added a commit to ruimoreira/ansible that referenced this pull request Apr 22, 2019

@nitzmahone

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Yeah, should probably be backported to 2.7 as well. 2.8.0rc1 is Thursday, so if we want it in there, the backport PR probably needs to be filed today (otherwise it's probably going to have to wait for 2.8.1)

@zikalino

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@nitzmahone thanks for reminding! I have this one + 2 more backports to do today

zikalino added a commit to VSChina/ansible that referenced this pull request Apr 24, 2019

zikalino added a commit to VSChina/ansible that referenced this pull request Apr 24, 2019

abadger added a commit that referenced this pull request Apr 24, 2019

fix for removing subscripion_id from resource facts (#55203) (#55685)
* adding changelog

* fix for removing subscripion_id from resource facts (#55203)

(cherry picked from commit 48cb681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.