fix for removing subscripion_id from resource facts #55203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
HI @nitzmahone could you pls look at this PR? although we found that subscription_id no_log=True will cause subscrption_id in outputed resource_id been masked as |
ansibot
removed
the
needs_triage
yungezz
approved these changes
Apr 16, 2019
ansibot
added
community_review
|
@zikalino could you pls backport this fix? |
|
Yeah, should probably be backported to 2.7 as well. 2.8.0rc1 is Thursday, so if we want it in there, the backport PR probably needs to be filed today (otherwise it's probably going to have to wait for 2.8.1) |
|
@nitzmahone thanks for reminding! I have this one + 2 more backports to do today |
zikalino
pushed a commit
to VSChina/ansible
that referenced
this pull request
Apr 24, 2019
(cherry picked from commit 48cb681)
abadger
pushed a commit
that referenced
this pull request
Apr 24, 2019
amuraleedhar
pushed a commit
to amuraleedhar/ansible
that referenced
this pull request
May 21, 2019
…nsible#55685) * adding changelog * fix for removing subscripion_id from resource facts (ansible#55203) (cherry picked from commit 48cb681)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is fixing following issue:
#55047
subscription_id is being removed from all returned resource urls when parameter subscription_id is specified.
in 99.99% of cases subscription_id is returned & displayed in plain text anyway, as subscription_id parameter is not commonly used.
ISSUE TYPE
COMPONENT NAME
all
ADDITIONAL INFORMATION