Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] openssl_csr: fix idempotency problems #55279

Merged
merged 1 commit into from Apr 16, 2019
Merged

[2.8] openssl_csr: fix idempotency problems #55279

merged 1 commit into from Apr 16, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #55142 to stable-2.8.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr

@felixfontein
openssl_csr: fix idempotency problems (ansible#55142)
1838efa 
* Add test for generating a CSR with everything, and testing idempotency.

* Proper SAN normalization before comparison.

* Fix check in cryptography backend.

* Convert SANs to text. Update comments.

* Add changelog.

(cherry picked from commit cb5c57b)
@felixfontein felixfontein mentioned this pull request Apr 15, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Apr 15, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Apr 15, 2019
@abadger abadger merged commit 9cdc204 into ansible:stable-2.8 Apr 16, 2019
@abadger
Copy link
Contributor

abadger commented Apr 16, 2019

Merged for 2.8.0rc1

@felixfontein felixfontein deleted the backport/2.8/55142 branch April 17, 2019 04:08
@felixfontein
Copy link
Contributor Author

@abadger thanks for merging this and the others!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @abadger @sivel