Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] openssl_csr: fix idempotency problems #55279

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@felixfontein
Copy link
Contributor

commented Apr 15, 2019

SUMMARY

Backport of #55142 to stable-2.8.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr

openssl_csr: fix idempotency problems (#55142)
* Add test for generating a CSR with everything, and testing idempotency.

* Proper SAN normalization before comparison.

* Fix check in cryptography backend.

* Convert SANs to text. Update comments.

* Add changelog.

(cherry picked from commit cb5c57b)
@ansibot

This comment has been minimized.

@abadger abadger merged commit 9cdc204 into ansible:stable-2.8 Apr 16, 2019

1 check passed

Shippable Run 119245 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Merged for 2.8.0rc1

@felixfontein felixfontein deleted the felixfontein:backport/2.8/55142 branch Apr 17, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@abadger thanks for merging this and the others!

@sivel sivel removed the needs_triage label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.