Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware_guest: remove guest_id check when use template #55281

Merged
merged 1 commit into from May 9, 2019
Merged

VMware_guest: remove guest_id check when use template #55281

merged 1 commit into from May 9, 2019

Conversation

Tomorrow9
Copy link
Contributor

SUMMARY

guest_id is not required if deploying a new VM from the template. If "guest_id" is set when deploy from the template, it will be ignored after this change.

Fixes #47646

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 15, 2019

cc @Akasurde @ckotte @dav1x @lparkes @nerzhul @pdellaert @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Apr 15, 2019
@Akasurde Akasurde mentioned this pull request Apr 15, 2019
Closed
@Akasurde Akasurde requested review from goneri and jillr April 15, 2019 09:19
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 15, 2019
goneri
goneri approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually make sense to allow the user to change the guestid of a template?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 23, 2019
@ansibot
Copy link
Contributor

ansibot commented May 9, 2019

cc @goneri
click here for bot help

@jillr
Copy link
Contributor

jillr commented May 9, 2019

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 9, 2019
@ansibot ansibot merged commit bfc3687 into ansible:devel May 9, 2019
@Tomorrow9 Tomorrow9 deleted the fix_pr47646 branch May 14, 2019 07:40
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@Tomorrow9 @ndclt
remove guest_id check when use template (ansible#55281)
5a89405
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMware: vmware_guest module errors out while creating a VM (windows 2008R2)
5 participants
@Tomorrow9 @ansibot @jillr @goneri @Akasurde