Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_acl: some platforms/versions raise when no ACLs are present #55609

Merged
merged 4 commits into from
May 2, 2019
Merged

nxos_acl: some platforms/versions raise when no ACLs are present #55609

merged 4 commits into from
May 2, 2019

Commits on Apr 22, 2019

  1. nxos_acl may fail with IndexError: list index out of range while … 

    …attempting to delete a non-existent ACL.

The failure occurs when the `acl` var is an empty list.
    @chrisvanheuveln
    chrisvanheuveln committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    1cec88b View commit details
    Browse the repository at this point in the history

  2. nxos_acl: catch 501 'Structured output unsupported' when no ACLs present 

    With some older image versions, `show ip access-list | json` will raise a 501 error indicating `'Structured output unsupported'` when there are no access-lists configured. This change turns off the `check_rc` and then looks for the failure condition.
    @chrisvanheuveln
    chrisvanheuveln committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    ac3d72c View commit details
    Browse the repository at this point in the history

  3. Fix kwarg

    @chrisvanheuveln
    chrisvanheuveln committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    4561ee2 View commit details
    Browse the repository at this point in the history

  4. Fix lint issues

    @chrisvanheuveln
    chrisvanheuveln committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    f0c7822 View commit details
    Browse the repository at this point in the history