Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vultr_server: fix idempotency for private network and IPv6 options #55619

Merged
merged 2 commits into from
Apr 23, 2019
Merged

vultr_server: fix idempotency for private network and IPv6 options #55619

merged 2 commits into from
Apr 23, 2019

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Apr 22, 2019

SUMMARY

Fix an idempotency issue with the options private_network_enabled and ipv6_enabled

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vultr_server

ADDITIONAL INFORMATION

The idempotency test for ipv6_enabled did not have the option, that is why it was not discovered by integration tests.

@ansibot
Copy link
Contributor

ansibot commented Apr 22, 2019

cc @Spredzy
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vultr Vultr community labels Apr 22, 2019
@resmo resmo merged commit 1705ef5 into ansible:devel Apr 23, 2019
@resmo resmo deleted the fix/vultr_server_idempotency branch April 23, 2019 19:22
This was referenced Apr 24, 2019
Merged
Merged
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Apr 24, 2019
abadger pushed a commit that referenced this pull request Apr 24, 2019
@resmo @abadger
vultr_server: fix idempotency for private network and IPv6 options (#…
4cd7c29 
…55619)

* vultr_server: fix idempotency for private network and IPv6 options

* add changelog

(cherry picked from commit 1705ef5)
abadger pushed a commit that referenced this pull request Apr 25, 2019
@resmo @abadger
vultr_server: fix idempotency for private network and IPv6 options (#…
8a8c9ed 
…55619)

* vultr_server: fix idempotency for private network and IPv6 options

* add changelog

(partly cherry picked from commit 1705ef5)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@resmo @ansibot @bcoca