Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding final functionapp settings #55693

Merged
merged 3 commits into from Apr 24, 2019
Merged

adding final functionapp settings #55693

merged 3 commits into from Apr 24, 2019

Conversation

zikalino
Copy link
Contributor

SUMMARY

This is final fix for azure_rm_functionapp.
Adding WEBSITES_ENABLE_APP_SERVICE_STORAGE and AzureWebJobsStorage properties by default.
Otherwise user will have to add them manually or function app won't work 100% correctly. (some features in the portal disabled)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_functionapp

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 24, 2019
@zikalino zikalino requested a review from yungezz April 24, 2019 06:47
yungezz
yungezz suggested changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change fragment?

@yungezz
Copy link
Contributor

yungezz commented Apr 24, 2019

shipit

@ansibot ansibot added owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Apr 24, 2019
@zikalino zikalino merged commit 8de2acb into ansible:devel Apr 24, 2019
@zikalino zikalino deleted the final-function-app-settings branch April 24, 2019 07:02
zikalino pushed a commit to VSChina/ansible that referenced this pull request Apr 24, 2019
adding final functionapp settings (ansible#55693)
9635ba7 
(cherry picked from commit 8de2acb)
abadger pushed a commit that referenced this pull request Apr 24, 2019
@abadger
Backport/2.8/55693 (#55698)
1453114 
* adding final functionapp settings (#55693)

(cherry picked from commit 8de2acb)

* +changelog
amuraleedhar pushed a commit to amuraleedhar/ansible that referenced this pull request May 21, 2019
Backport/2.8/55693 (ansible#55698)
fe18080 
* adding final functionapp settings (ansible#55693)

(cherry picked from commit 8de2acb)

* +changelog
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zikalino @ansibot @yungezz