ovirt vmpools creating vm options #55815

mnecas · 2019-04-26T13:05:30Z

SUMMARY

ovirt vmpools creating vm options
@machacekondra what other options should I add?

Fixes #55344

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

ansibot · 2019-04-26T13:14:25Z

cc @mwperina
click here for bot help

machacekondra · 2019-04-27T05:47:01Z

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py

    id: 00000000-0000-0000-0000-000000000000
    name: "new_pool_name"
+
+- name: Create pool with vm


Create vm pool and override the pool values.

ansibot · 2019-05-25T01:53:34Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E305 DOCUMENTATION.options.vm.suboption: extra keys not allowed @ data['options']['vm']['suboption']. Got {'comment': {'description': ['Comment of the Virtual Machine.']}, 'timezone': {'description': ['Sets time zone offset of the guest hardware clock.', 'For example C(Etc/GMT)']}, 'memory': {'description': ['Amount of memory of the Virtual Machine. Prefix uses IEC 60027-2 standard (for example 1GiB, 1024MiB).', 'Default value is set by engine.']}, 'memory_guaranteed': {'description': ['Amount of minimal guaranteed memory of the Virtual Machine. Prefix uses IEC 60027-2 standard (for example 1GiB,...

click here for bot help

ansibot · 2019-06-03T08:54:38Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E305 DOCUMENTATION.options.vm.suboption: extra keys not allowed @ data['options']['vm']['suboption']. Got {'comment': {'description': ['Comment of the Virtual Machine.']}, 'timezone': {'description': ['Sets time zone offset of the guest hardware clock.', 'For example C(Etc/GMT)']}, 'memory': {'description': ['Amount of memory of the Virtual Machine. Prefix uses IEC 60027-2 standard (for example 1GiB, 1024MiB).', 'Default value is set by engine.']}, 'memory_guaranteed': {'description': ['Amount of minimal guaranteed memory of the Virtual Machine. Prefix uses IEC 60027-2 standard (for example 1GiB,...

click here for bot help

machacekondra · 2019-06-04T08:43:31Z

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py

@@ -81,31 +81,118 @@
        description:
            - "Number of VMs in the pool."
            - "Default value is set by engine."
+    vm:
+        description:
+            - "For creating vm poool without editing template."


ansibot · 2019-06-04T15:11:52Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 768, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 298, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 382, in parse_block_sequence_entry
    if self.check_token(BlockEntryToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 115, in check_token
    while self.need_more_tokens():
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 152, in need_more_tokens
    self.stale_possible_simple_keys()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 292, in stale_possible_simple_keys
    "could not find expected ':'", self.get_mark())
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 121, column 21:
                        To manage NICs of the VM in more ... 
                        ^
could not find expected ':'
  in "<unicode string>", line 122, column 9:
            version_added: 2.9
            ^
make: *** [modules] Error 1

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E324 Argument 'poll_interval' in argument_spec defines default as (3) but documentation defines default as (None)
lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E324 Argument 'timeout' in argument_spec defines default as (180) but documentation defines default as (None)
lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E324 Argument 'wait' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent']) but documentation defines choices as ([])
lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:0:0: E326 Argument 'type' in argument_spec defines choices as (['automatic', 'manual']) but documentation defines choices as ([])
lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:148:9: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py:148:9: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

machacekondra

shipit

mnecas added 4 commits April 23, 2019 15:03

ovirt vm pools add vm vars

560a699

remove cloud init persist

457c5bd

ovirt vm pools add nics

c4cbf78

ovirt vm pools add vm docs

1969422

ovirt vm pools update docs

f479930

machacekondra reviewed Apr 27, 2019

View reviewed changes

ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 27, 2019

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label May 2, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 8, 2019

ovirt vm pools update cloud_init docs

88e1c7e

ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 3, 2019

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jun 3, 2019

machacekondra reviewed Jun 4, 2019

View reviewed changes

update ovirt_vm_pools docs

603e821

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jun 4, 2019

correct ovirt vm pools version_added

4ed9ddd

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 4, 2019

machacekondra approved these changes Jun 5, 2019

View reviewed changes

ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 5, 2019

ansibot merged commit 6e9eac7 into ansible:devel Jun 5, 2019

ansible locked and limited conversation to collaborators Aug 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ovirt vmpools creating vm options #55815

ovirt vmpools creating vm options #55815

mnecas commented Apr 26, 2019 •

edited

ansibot commented Apr 26, 2019

machacekondra Apr 27, 2019

ansibot commented May 25, 2019

ansibot commented Jun 3, 2019

machacekondra Jun 4, 2019

ansibot commented Jun 4, 2019

machacekondra left a comment

ovirt vmpools creating vm options #55815

ovirt vmpools creating vm options #55815

Conversation

mnecas commented Apr 26, 2019 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Apr 26, 2019

machacekondra Apr 27, 2019

Choose a reason for hiding this comment

ansibot commented May 25, 2019

ansibot commented Jun 3, 2019

machacekondra Jun 4, 2019

Choose a reason for hiding this comment

ansibot commented Jun 4, 2019

machacekondra left a comment

Choose a reason for hiding this comment

mnecas commented Apr 26, 2019 •

edited