Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PhysicalResourceId KeyError when stack in ROLLBACK state #55990

Merged
merged 1 commit into from Jul 19, 2019

Commits on May 1, 2019

  1. Fixes PhysicalResourceId KeyError when stack in ROLLBACK state

    Currently, if we try to get facts from a CloudFormation Stack that is in
    `ROLLBACK` state, this module will throw a `KeyError` exception, given that the
    `PhysicalResourceId` key does not exist for every resource in the
    stack_resource_list. Using the dict `get` method would set the value to None
    (null) if the key does not exist:
    
    ```
       "stack_resources": {
           "AppSecurityGroup": "sg-XXXXXXXXXX",
           "testawsngxLaunchConfig": null,
           "testawsngxLoadBalancer": "arn:aws:elasticloadbalancing:eu-west-1:XXXXXXXX:loadbalancer/net/test-test-1P5RFLQ266GGP/XXXXXXXXXXXX",
           "testawsngxTargetGroup": "arn:aws:elasticloadbalancing:eu-west-1:XXXXXXX:targetgroup/test-test-1LDHMLKNWNA82/XXXXXXXXXXXX"
       },
    ```
    
    Fixes issue ansible#38033
    Denis Afonso committed May 1, 2019
    Configuration menu
    Copy the full SHA
    787808f View commit details
    Browse the repository at this point in the history