Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't validate ip address for mgmt interface #56136

Merged
merged 1 commit into from May 9, 2019
Merged

Don't validate ip address for mgmt interface #56136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/targets/eos_facts/tests/cli/default_facts.yaml
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
# Items from those subsets are present
- "result.ansible_facts.ansible_net_filesystems is defined" #hw
- "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw
- "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces
- "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we can assert about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but we should update the testing here to create the ip address first.


# ... and not present
- "result.ansible_facts.ansible_net_config is not defined" # config
Expand Down
2 changes: 1 addition & 1 deletion test/integration/targets/eos_facts/tests/cli/not_hardware.yaml
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
- "'hardware' not in result.ansible_facts.ansible_net_gather_subset"

# Items from those subsets are present
- "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces
- "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces
# ... and not present
- "result.ansible_facts.ansible_net_filesystems is not defined"

Expand Down
2 changes: 1 addition & 1 deletion test/integration/targets/eos_facts/tests/eapi/default_facts.yaml
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@
# Items from those subsets are present
- "result.ansible_facts.ansible_net_filesystems is defined" #hw
- "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw
- "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces
- "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces

# ... and not present
- "result.ansible_facts.ansible_net_config is not defined" # config
Expand Down
2 changes: 1 addition & 1 deletion test/integration/targets/eos_facts/tests/eapi/not_hardware.yaml
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@
- "'hardware' not in result.ansible_facts.ansible_net_gather_subset"

# Items from those subsets are present
- "result.ansible_facts.ansible_net_interfaces.Management1.ipv4.masklen > 1" # interfaces
- "result.ansible_facts.ansible_net_interfaces.Management1" # interfaces
# ... and not present
- "result.ansible_facts.ansible_net_filesystems is not defined"

Expand Down