Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update na_ontap_volume.py #56207

Closed
wants to merge 1 commit into from
Closed

Update na_ontap_volume.py #56207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ansible/modules/storage/netapp/na_ontap_volume.py
View file
Open in desktop
Expand Up @@ -78,7 +78,9 @@
type:
description:
- The volume type, either read-write (RW) or data-protection (DP).

choices: ['rw', 'dp']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @carchi8py pointed out, the ZAPI documentation shows 4 possible values:

  • 'rw' - read-write volume (default),
  • 'ls' - load-sharing volume,
  • 'dp' - data-protection volume,
  • 'dc' - data-cache volume (FlexCache)

(this is from SDK documentation for 9.5)
even though the CLI allows only 2 values.

I'll check with the product team why there is such an inconsistency.

This is also why I am always conflicted with choices. On one hand, this is a great way to help the end users. On the other hand, we need to support all possible choices for 9.1 to 9.6. And if 9.7 introduces a new value, it will require a change in the module. While a free format fields give a lot of flexibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to wonder if this is a bug in the ZAPI documentation. There are only 2 places where ls and dc are mentioned.

We should try and see if the ZAPI actually accept these values.

Anyway, this is not a critical fix, so it's better to delay until we know for sure this change would not break anything.

default: rw

policy:
description:
- Name of the export policy.
Expand Down