Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in case of empty hosts list in playbook #56354

Merged
merged 1 commit into from May 21, 2019
Merged

Raise error in case of empty hosts list in playbook #56354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ansible/playbook/play.py
View file
Open in desktop
Expand Up @@ -103,6 +103,8 @@ def get_name(self):
@staticmethod
def load(data, variable_manager=None, loader=None, vars=None):
if ('name' not in data or data['name'] is None) and 'hosts' in data:
if data['hosts'] is None or all(host is None for host in data['hosts']):
raise AnsibleParserError("Hosts list cannot be empty - please check your playbook")
cinek810 marked this conversation as resolved.
Show resolved Hide resolved
if isinstance(data['hosts'], list):
data['name'] = ','.join(data['hosts'])
else:
Expand Down