Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for Oracle cloud infrastructure - Updated #56410

Merged
merged 2 commits into from May 14, 2019
Merged

Initial commit for Oracle cloud infrastructure - Updated #56410

merged 2 commits into from May 14, 2019

Conversation

nalsaber
Copy link
Contributor

SUMMARY

Update license and logging as recommended by (Revert oracle #56364)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

Oracle cloud infrastructure Manage Virtual Cloud Networks(VCN) module

ADDITIONAL INFORMATION

Files Submitted:
lib/ansible/module_utils/oracle/init.py
lib/ansible/module_utils/oracle/oci_logging.yaml
lib/ansible/module_utils/oracle/oci_utils.py
lib/ansible/modules/cloud/oracle/init.py
lib/ansible/modules/cloud/oracle/oci_vcn.py
lib/ansible/plugins/doc_fragments/oracle.py
lib/ansible/plugins/doc_fragments/oracle_creatable_resource.py
lib/ansible/plugins/doc_fragments/oracle_display_name_option.py
lib/ansible/plugins/doc_fragments/oracle_name_option.py
lib/ansible/plugins/doc_fragments/oracle_tags.py
lib/ansible/plugins/doc_fragments/oracle_wait_options.py

@nalsaber
Initial commit - Oracle modules
4d78b92 
Revert "Revert oracle (ansible#56364)"

This reverts commit eefc90b.
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 botmeta This PR modifies the BOTMETA.yml and this requires special attention! cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. oracle support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 14, 2019
@nalsaber
Copy link
Contributor Author

@mattclay please approve. I would like to backport this change to 2.8 also.

mattclay
mattclay reviewed May 14, 2019
View reviewed changes
lib/ansible/modules/cloud/oracle/oci_vcn.py Outdated
@@ -23,7 +20,7 @@
- This module allows the user to create, delete and update virtual cloud networks(VCNs) in OCI.
The complete Oracle Cloud Infrastructure Ansible Modules can be downloaded from
U(https://github.com/oracle/oci-ansible-modules/releases).
version_added: "2.8"
version_added: "2.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the version added as 2.8 -- we'll ignore that CI failure and merge (assuming everything else is OK).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattclay done

@abadger
Copy link
Contributor

abadger commented May 14, 2019

The licensing changes look good to me. At some point in the future you may need to look into using the module_utils/basic.py log handling instead of your ad hoc stuff but this is already an improvement over the current status so +1 from me.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 14, 2019
@mattclay mattclay merged commit e98e987 into ansible:devel May 14, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label May 14, 2019
@mattclay mattclay mentioned this pull request May 14, 2019
Closed
@mattclay
Copy link
Member

@nalsaber Thanks for the quick response on updating the license.

@abadger I've opened a backport PR for the license changes in stable-2.8: #56417

@nalsaber
Copy link
Contributor Author

The licensing changes look good to me. At some point in the future you may need to look into using the module_utils/basic.py log handling instead of your ad hoc stuff but this is already an improvement over the current status so +1 from me.
Sure, I will check it.

Thanks for the quick merge!

@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 botmeta This PR modifies the BOTMETA.yml and this requires special attention! cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. oracle support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nalsaber @abadger @mattclay @ansibot