Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pkg_mgr.py for Amazon Linux support #56618

Merged
merged 7 commits into from
May 30, 2019
Merged

update pkg_mgr.py for Amazon Linux support #56618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bbd65a8
update pkg_mgr.py for Amazon Linux support
huntertj May 19, 2019
54b16b5
added changelog for 56618
huntertim-bah May 24, 2019
8b84208
moved the Amazon Linux conditional up one level
huntertim-bah May 24, 2019
4876ef7
space typo on pkg_mgr_name
huntertim-bah May 24, 2019
89fc5bf
Revert "update pkg_mgr.py for Amazon Linux support"
huntertim-bah May 24, 2019
3140871
update the RHEL else block as explaination
huntertim-bah May 24, 2019
2bb7d31
make changelog use LF instead of CRLF
huntertim-bah May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/56618-update-pkg_mgr.py-for-Amazon-Linux-support.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- pkg_mgr - Ansible 2.8.0 failing to install yum packages on Amazon Linux (https://github.com/ansible/ansible/issues/56583)
6 changes: 4 additions & 2 deletions lib/ansible/module_utils/facts/system/pkg_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@ def _check_rh_versions(self, pkg_mgr_name, collected_facts):
# If there's some new magical Fedora version in the future,
# just default to dnf
pkg_mgr_name = 'dnf'
elif collected_facts['ansible_distribution'] == 'Amazon':
pkg_mgr_name = 'yum'
else:
# If it's not Fedora and it's Red Hat family of distros, assume RHEL
# or a clone. For versions of RHEL < 8 that Ansible supports, the
# If it's not one of the above and it's Red Hat family of distros, assume
# RHEL or a clone. For versions of RHEL < 8 that Ansible supports, the
# vendor supported official package manager is 'yum' and in RHEL 8+
# (as far as we know at the time of this writing) it is 'dnf'.
# If anyone wants to force a non-official package manager then they
Expand Down