Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sx5 868 pr keycloak group #56741

Closed
wants to merge 71 commits into from

Conversation

elfelip
Copy link

@elfelip elfelip commented May 21, 2019

SUMMARY

Add functionalities to keycloak_group module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

keycloak_group

ADDITIONAL INFORMATION

Add role management to Keycloak_group module. Add a new list type for attributes to support Ansible variable as name.

elfelip added 30 commits May 1, 2019 15:04
keycloak_arguments_spec. The are in conflict with keycloak_user module
to come.
@ansibot
Copy link
Contributor

ansibot commented May 21, 2019

@elfelip this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 21, 2019

@elfelip This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels May 21, 2019
Copy link
Contributor

@rrey rrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !
I think this PR contains things that are unrelated to the PR. (The netapp stuff for example).
There is a lot of stuff regarding roles, and I think a module that handles the roles in keycloak would make more sense.

@elfelip
Copy link
Author

elfelip commented Feb 3, 2020

Hi !
I think this PR contains things that are unrelated to the PR. (The netapp stuff for example).
There is a lot of stuff regarding roles, and I think a module that handles the roles in keycloak would make more sense.

Hi Rémi.
Maybe I can do cleaner PR without netapp stuff. Roles in this context are used to grant realm roles and clients roles to the group. I also did a pull request for a keycloak module to manage realm roles. Client Roles are managed by the keycloak_client PR.

@rrey
Copy link
Contributor

rrey commented Feb 3, 2020

Don’t you think that role management would deserve a dedicated module ?

@elfelip
Copy link
Author

elfelip commented Feb 3, 2020

Hi @rrey
We devloped the following modules for Keycloak.
keycloak_client.py, keycloak_component.py, keycloak_identity_provider.py, keycloak_role.py, keycloak_authentication.py, keycloak_group.py, keycloak_realm.py and keycloak_user.py
They are used to manage our production Keycloak environment for almost two years now. We have integration tests running every day on those modules to test them against new Keycloak/Ansible versions.
Our main repository is https://github.com/Inspq/ansible.git
Integrated tests are in the test/units/modules/identity/keycloak/ directory of that repo.
My name is Philippe Gauthier and I am from Quebec. We can user another channel to talk about those modules in french.
Thankyou.

@mkrizek
Copy link
Contributor

mkrizek commented Aug 18, 2020

Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.general.

Please re-submit this issue in the above repository.

If you have further questions please stop by IRC or the mailing list:

@mkrizek mkrizek closed this Aug 18, 2020
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 18, 2020
@ansible ansible locked and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. identity Identity category merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants