Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated comparison method so old values are copied if necessary #56896

Closed
wants to merge 8 commits into from
Closed

updated comparison method so old values are copied if necessary #56896

wants to merge 8 commits into from

Conversation

zikalino
Copy link
Contributor

SUMMARY

This handles the situation when user doesn't specify some parameters that were specified in the portal or via some other method.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_azurefirewall

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented May 24, 2019

cc @haroldwongms @needgithubid @nitzmahone @trstringer @yungezz @yuwzho
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 24, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request May 25, 2019
Closed
@Fred-sun
Copy link
Contributor

@yungezz @yuwzho review_need

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 30, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 31, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 8, 2019
@Fred-sun
Copy link
Contributor

@yungezz @yuwzho

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 27, 2019
@Fred-sun
Copy link
Contributor

Fred-sun commented Jul 1, 2019

@zikalino Please resolve the conflicting files when you're free! Thank you very much!

@Fred-sun
Copy link
Contributor

@zikalino Need your help to solve the conflict! Thanks a lot!

@Fred-sun
Copy link
Contributor

@zikalino Please resolve the conflicts and push for review when you're free! Thank you very much!

@zikalino zikalino closed this Aug 29, 2019
@zikalino zikalino deleted the upgrade-firewall-idempotence branch August 29, 2019 05:03
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 29, 2019
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @ansibot @Fred-sun @sivel