Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make env setup faster #57042

Closed
wants to merge 1 commit into from
Closed

make env setup faster #57042

wants to merge 1 commit into from

Conversation

ptux
Copy link
Contributor

@ptux ptux commented May 28, 2019

SUMMARY

replace find exec with xargs

ISSUE TYPE
  • minor change Pull Request
COMPONENT NAME

env-setup
env-setup.fish

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 28, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 28, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 5, 2019
@ptux
Copy link
Contributor Author

ptux commented Jun 7, 2019

anybody?

@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Jun 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@ptux Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 31, 2019
gundalow
gundalow requested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are subtle things here that could go wrong given the variety of operating systems that can be used to run Ansible.

Have you seen these steps taking a long time? This script should only be evoked once.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 31, 2019
@gundalow gundalow added pr_day Has been reviewed during a PR review Day candidate_to_close Think we can close this, though need to check with Core labels Sep 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Sep 3, 2019

Also -exec is safer with filenames that need closing

I'm going to close this

@gundalow gundalow closed this Sep 3, 2019
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow requested changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 candidate_to_close Think we can close this, though need to check with Core needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. pr_day Has been reviewed during a PR review Day small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ptux @ansibot @gundalow @bcoca