Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware Tools Connector does not support pipelining #57237

Merged
merged 1 commit into from Jul 22, 2019
Merged

VMware Tools Connector does not support pipelining #57237

merged 1 commit into from Jul 22, 2019

Conversation

agowa
Copy link
Contributor

@agowa agowa commented May 31, 2019

SUMMARY

The vmware_tools connector has self.has_pipelining set to true, even though pipelining is not supported. Therefore all plays fail with invalid command that try to use pipelining.

Fixes #57234

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/connection/vmware_tools.py

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 31, 2019
@Akasurde Akasurde requested review from Akasurde and bcoca June 1, 2019 15:20
@Akasurde Akasurde added vmware VMware community and removed needs_triage Needs a first human triage before being processed. labels Jun 1, 2019
@Akasurde
Copy link
Member

Akasurde commented Jun 1, 2019

@jamescassell @dericcrago Could you please review this ? Thanks.

@Akasurde Akasurde mentioned this pull request Jun 1, 2019
Closed
jamescassell
jamescassell approved these changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

Thanks for the fix!

@ansibot
Copy link
Contributor

ansibot commented Jun 9, 2019

cc @Tomorrow9 @dav1x @goneri @pgbidkar @warthog9
click here for bot help

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 9, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 3, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 19, 2019
@Akasurde Akasurde merged commit 252d1b7 into ansible:devel Jul 22, 2019
@agowa agowa deleted the patch-7 branch July 22, 2019 08:53
@ansible ansible locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamescassell jamescassell jamescassell approved these changes

@Akasurde Akasurde Awaiting requested review from Akasurde

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMware Tools Connector does not support pipelining
4 participants
@agowa @Akasurde @ansibot @jamescassell