Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt: Resolve also list of hrefs #57299

Merged
merged 1 commit into from Jun 6, 2019

Conversation

machacekondra
Copy link
Contributor

SUMMARY

This PR add fixes to resolve also list of href in case of using fetch_nested=true

Direct elements works, e.g. disks:
<quota href="/ovirt-engine/api/datacenters/87bc2e30-f3b1-11e8-aa7d-001a4a013f36/quotas/96f2a2e4-f3b1-11e8-82b6-001a4a013f36" id="96f2a2e4-f3b1-11e8-82b6-001a4a013f36"/>
-->
"quota": {
                "href": "/ovirt-engine/api/datacenters/87bc2e30-f3b1-11e8-aa7d-001a4a013f36/quotas/96f2a2e4-f3b1-11e8-82b6-001a4a013f36",
                "id": "96f2a2e4-f3b1-11e8-82b6-001a4a013f36",
                "name": "Default"
            },

But when the element is in a list or other element, it doesn't work, e.g. in disks:

        <storage_domains>
            <storage_domain href="/ovirt-engine/api/storagedomains/82ceb4c9-e844-4fc7-b0ff-559052e6301f" id="82ceb4c9-e844-4fc7-b0ff-559052e6301f"/>
        </storage_domains>
-->
            "storage_domains": [
                {
                    "href": "/ovirt-engine/api/storagedomains/82ceb4c9-e844-4fc7-b0ff-559052e6301f",
                    "id": "82ceb4c9-e844-4fc7-b0ff-559052e6301f"
                }
            ],

or template:

        <version>
            <version_name>base version</version_name>
            <version_number>1</version_number>
            <base_template href="/ovirt-engine/api/templates/264640fc-1b51-4263-995b-47e3e9dd3c8f" id="264640fc-1b51-4263-995b-47e3e9dd3c8f"/>
        </version>
-->
            "version": {
                "base_template": {
                    "href": "/ovirt-engine/api/templates/264640fc-1b51-4263-995b-47e3e9dd3c8f",
                    "id": "264640fc-1b51-4263-995b-47e3e9dd3c8f"
                },
                "version_name": "base version",
                "version_number": 1
            },
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 3, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 3, 2019
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jun 3, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core labels Jun 3, 2019
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 3, 2019
@resmo resmo merged commit d887393 into ansible:devel Jun 6, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud ovirt oVirt and RHV community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants