Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one_vm: moved to pyone added Persisten Deployment #57393

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@meerkampdvv
Copy link

commented Jun 5, 2019

SUMMARY

Moved from python-oca to pyone which is the current python module shipped with Opennebula
Added Persistent deployment of VMs. #49550

ISSUE TYPE
  • Feature Pull Request
ADDITIONAL INFORMATION

In the latest official documentation [1] is said that pyone is the current python module to be installed with OpenNebula, so if it is not compatible with python-oca, the ansible module should use pyone instead of python-oca.

[1] http://docs.opennebula.org/5.8/deployment/opennebula_installation/frontend_installation.html


moved to pyone added Persisten Deployment
Moved from python-oca to pyone.
Added Persistent deployment of VMs.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:0: syntax-error invalid syntax (<unknown>, line 838)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 768, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 298, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 838
    except pyone.OneException,e:
                             ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: except pyone.OneException,e:

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: except pyone.OneException,e:

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: except pyone.OneException,e:

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: except pyone.OneException,e:

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 20 errors:

lib/ansible/modules/cloud/opennebula/one_vm.py:595:39: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:595:42: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:595:45: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:633:5: E722 do not use bare 'except'
lib/ansible/modules/cloud/opennebula/one_vm.py:717:1: E303 too many blank lines (3)
lib/ansible/modules/cloud/opennebula/one_vm.py:730:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/opennebula/one_vm.py:792:44: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:862:19: E272 multiple spaces before keyword
lib/ansible/modules/cloud/opennebula/one_vm.py:873:33: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:873:36: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:873:39: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:924:161: E501 line too long (174 > 160 characters)
lib/ansible/modules/cloud/opennebula/one_vm.py:989:161: E501 line too long (168 > 160 characters)
lib/ansible/modules/cloud/opennebula/one_vm.py:1034:53: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:1193:34: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:1221:17: E722 do not use bare 'except'
lib/ansible/modules/cloud/opennebula/one_vm.py:1285:45: E231 missing whitespace after ','
lib/ansible/modules/cloud/opennebula/one_vm.py:1322:91: E202 whitespace before ')'
lib/ansible/modules/cloud/opennebula/one_vm.py:1388:161: E501 line too long (165 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:838:30: python-syntax-error invalid syntax (<unknown>, line 838)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/opennebula/one_vm.py:791:116: undefined-variable Undefined variable 'disks_num'
lib/ansible/modules/cloud/opennebula/one_vm.py:1471:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/cloud/opennebula/one_vm.py:728:161: E501 line too long (164 > 160 characters)
lib/ansible/modules/cloud/opennebula/one_vm.py:923:5: E125 continuation line with same indent as next logical line
lib/ansible/modules/cloud/opennebula/one_vm.py:1471:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/opennebula/one_vm.py:1471:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: E309 version_added for new option (persistent) should be '2.9'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/opennebula/one_vm.py:1470:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot ansibot added the ci_verified label Jun 5, 2019

@ansibot ansibot removed the ci_verified label Jun 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:792:116: undefined-variable Undefined variable 'disks_num'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/opennebula/one_vm.py:729:17: E122 continuation line missing indentation or outdented

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: E307 version_added should be '2.6'. Currently '2.9'
lib/ansible/modules/cloud/opennebula/one_vm.py:0:0: E309 version_added for new option (persistent) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.