Update na_elementsw_access_group.py

[arcticgenes]

SUMMARY

account_id was not being passed correctly with username. String can now be passed and will return correctly.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

na_elementsw_access_group

ADDITIONAL INFORMATION

  na_elementsw_access_group:
    hostname: "{{ elementsw_hostname }}"
    username: "{{ elementsw_username }}"
    password: "{{ elementsw_password }}"
    account_id: "{{ nacluster_accountname }}"
    state: present
    name: "{{ navolume_accessgroup_name }}"
    volumes:
      - "{{ volume_name }}"

    "changed": false,
    "rc": 1
}

MSG:

MODULE FAILURE
See stdout/stderr for the exact error


MODULE_STDERR:

2019-06-06 23:31:26,392 - solidfire.Element - INFO - {"method": "GetAPI", "id": 0, "params": {}}
2019-06-06 23:31:26,577 - solidfire.Element - INFO - Connected to 10.39.48.5 using API version 10.4
2019-06-06 23:31:26,578 - solidfire.Element - INFO -

                                               77
                                              7777
                                               77
                                               ==
                             77IIIIIIIIIIIIIIIIII777
                           =7                       7=
                           7                         7
                          =7                         7=
                          =7                         7=
                         =77   7777777777777777777   77=
                        7777  777777777777777777777  7777
                        7777   7777777777777777777   7777
                         =77                         77=
                          =7                         7=
                           7                         7
                           7=                       =7
                            77=                   =77
                              =7777777777777777777=

                               ====IIIIIIIIII=====
                         =77777=                 =77777=
                     =777=                             =777=
                 =777=                                     =777=

                           NetApp SolidFire Version 10.4


2019-06-06 23:31:26,578 - solidfire.Element - INFO - {"method": "GetAccountByName", "id": 1, "params": {"username": "admin"}}
2019-06-06 23:31:26,731 - solidfire.Element - INFO - {"method": "ListVolumesForAccount", "id": 2, "params": {"accountID": "admin"}}
Traceback (most recent call last):
  File "/home/ubuntu/.ansible/tmp/ansible-tmp-1559863885.8599882-255882656119489/AnsiballZ_na_elementsw_access_group.py", line 114, in <module>
    _ansiballz_main()
  File "/home/ubuntu/.ansible/tmp/ansible-tmp-1559863885.8599882-255882656119489/AnsiballZ_na_elementsw_access_group.py", line 106, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/ubuntu/.ansible/tmp/ansible-tmp-1559863885.8599882-255882656119489/AnsiballZ_na_elementsw_access_group.py", line 49, in invoke_module
    imp.load_module('__main__', mod, module, MOD_DESC)
  File "/usr/lib/python3.5/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/usr/lib/python3.5/imp.py", line 170, in load_source
    module = _exec(spec, sys.modules[name])
  File "<frozen importlib._bootstrap>", line 626, in _exec
  File "<frozen importlib._bootstrap_external>", line 665, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/tmp/ansible_na_elementsw_access_group_payload_ma4h_aif/__main__.py", line 368, in <module>
  File "/tmp/ansible_na_elementsw_access_group_payload_ma4h_aif/__main__.py", line 364, in main
  File "/tmp/ansible_na_elementsw_access_group_payload_ma4h_aif/__main__.py", line 306, in apply
  File "/tmp/ansible_na_elementsw_access_group_payload_ma4h_aif/__main__.py", line 229, in get_volume_id
  File "/tmp/ansible_na_elementsw_access_group_payload_ma4h_aif/ansible_na_elementsw_access_group_payload.zip/ansible/module_utils/netapp_elementsw_module.py", line 96, in volume_exists
  File "/tmp/ansible_na_elementsw_access_group_payload_ma4h_aif/ansible_na_elementsw_access_group_payload.zip/ansible/module_utils/netapp_elementsw_module.py", line 52, in get_volume_id
  File "/usr/local/lib/python3.5/dist-packages/solidfire/__init__.py", line 5529, in list_volumes_for_account
    since=1.0
  File "/usr/local/lib/python3.5/dist-packages/solidfire/common/__init__.py", line 704, in send_request
    response["error"]["message"])
solidfire.common.ApiServerError: ApiServerError(method_name="ListVolumesForAccount", err_json=500 xInvalidParameterType accountID: Invalid type: expected uint64_t but found "admin"
)```

[ansibot]

cc @amit0701 @carchi8py @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

[lonico]

The issue is really in line 233

volume_id = self.elementsw_helper.volume_exists(volume, self.account_id)

it should be

volume_id = self.elementsw_helper.volume_exists(volume, self.account_id_valid)

as we are trying to preserver self.account_id for an error message. We want to preserve the original value.

(I agree it's a bit confusing as written, and could be better to use a new name for the original value)

[lonico]

Duplicate of #60887

[ansibot]

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

• lib/ansible/modules/storage/netapp/na_elementsw_access_group.py -> https://galaxy.ansible.com/red8labs/ontap

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md