Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.8] Fix RuntimeError on Python 3.8. #57520

Merged
merged 2 commits into from
Jun 10, 2019
Merged

[stable-2.8] Fix RuntimeError on Python 3.8. #57520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4dd630
[stable-2.8] Fix RuntimeError on Python 3.8.
mattclay Jun 7, 2019
77f8682
Add changelog fragment.
mattclay Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/runtime-error-3.8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
bugfixes:
- dellos9_facts - Fix RuntimeError on Python 3.8.
- na_ontap_quotas - Fix RuntimeError on Python 3.8.
4 changes: 2 additions & 2 deletions lib/ansible/modules/network/dellos9/dellos9_facts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,13 @@ def populate(self):
data = self.responses[0]
interfaces = self.parse_interfaces(data)

for key in interfaces.keys():
for key in list(interfaces.keys()):
if "ManagementEthernet" in key:
temp_parsed = interfaces[key]
del interfaces[key]
interfaces.update(self.parse_mgmt_interfaces(temp_parsed))

for key in interfaces.keys():
for key in list(interfaces.keys()):
if "Vlan" in key:
temp_parsed = interfaces[key]
del interfaces[key]
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/modules/storage/netapp/na_ontap_quotas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def apply(self):
elif cd_action == 'delete':
self.quota_entry_delete()
elif modify_quota is not None:
for key in modify_quota:
for key in list(modify_quota):
modify_quota[key.replace("_", "-")] = modify_quota.pop(key)
self.quota_entry_modify(modify_quota)
if modify_quota_status is not None:
Expand Down