Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn when trying to read missing cache file #57646

Closed
wants to merge 4 commits into from
Closed

Don't warn when trying to read missing cache file #57646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e14f29
Don't warn when trying to read missing cache file
steffann Jun 10, 2019
a502a7c
Only suppress the warning on errno.ENOENT
steffann Jun 10, 2019
a7ce24a
Create cache-file-missing-warning.yaml
steffann Jun 10, 2019
06dc61e
Fix formatting
steffann Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/cache-file-missing-warning.yaml
View file
Open in desktop
@@ -0,0 +1,2 @@
minor_changes:
- cache - do not show warning when cache file does not (yet) exist
5 changes: 4 additions & 1 deletion lib/ansible/plugins/cache/__init__.py
View file
Open in desktop
Expand Up @@ -153,7 +153,10 @@ def get(self, key):
raise AnsibleError("The cache file %s was corrupt, or did not otherwise contain valid data. "
"It has been removed, so you can re-run your command now." % cachefile)
except (OSError, IOError) as e:
display.warning("error in '%s' cache plugin while trying to read %s : %s" % (self.plugin_name, cachefile, to_bytes(e)))
if e.errno == errno.ENOENT:
display.v("'%s' cache plugin tried to read non-existent %s" % (self.plugin_name, cachefile))
else:
display.warning("error in '%s' cache plugin while trying to read %s : %s" % (self.plugin_name, cachefile, to_bytes(e)))
raise KeyError
except Exception as e:
raise AnsibleError("Error while decoding the cache file %s: %s" % (cachefile, to_bytes(e)))
Expand Down