Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/57257 option is marked as required but specifies a default #57750

Merged
merged 2 commits into from Jun 18, 2019
Merged

Backport/2.8/57257 option is marked as required but specifies a default #57750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
767664e
option is marked as required but specifies a default (#57257)
Jun 5, 2019
6908fc6
add a changelog fragment for PR 57750.
yuandongx Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/57750-option-is-marked-as-required-but-specifies-a-default.yml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- option is marked as required but specifies a default.(https://github.com/ansible/ansible/pull/57257)
6 changes: 3 additions & 3 deletions lib/ansible/modules/network/cloudengine/ce_reboot.py
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@
description:
- Safeguard boolean. Set to true if you're sure you want to reboot.
type: bool
default: false
required: true
save_config:
description:
- Flag indicating whether to save the configuration.
Expand Down Expand Up @@ -134,8 +134,8 @@ def main():
""" main """

argument_spec = dict(
confirm=dict(required=True, type='bool', default='false'),
save_config=dict(required=False, type='bool', default='false')
confirm=dict(required=True, type='bool'),
save_config=dict(default=False, type='bool')
)

argument_spec.update(ce_argument_spec)
Expand Down
1 change: 0 additions & 1 deletion test/sanity/validate-modules/ignore.txt
View file
Open in desktop
Expand Up @@ -464,7 +464,6 @@ lib/ansible/modules/network/cloudengine/ce_ntp.py E322
lib/ansible/modules/network/cloudengine/ce_ntp_auth.py E322
lib/ansible/modules/network/cloudengine/ce_ospf.py E322
lib/ansible/modules/network/cloudengine/ce_ospf_vrf.py E322
lib/ansible/modules/network/cloudengine/ce_reboot.py E317
lib/ansible/modules/network/cloudengine/ce_reboot.py E322
lib/ansible/modules/network/cloudengine/ce_rollback.py E322
lib/ansible/modules/network/cloudengine/ce_sflow.py E322
Expand Down