VMware: vsphere_copy IndexError: tuple index out of range

[lijok]

SUMMARY

hotfixes #58168

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vsphere_copy

ADDITIONAL INFORMATION

before:

Traceback (most recent call last):
  File "/home/user/.ansible/tmp/ansible-tmp-1561111440.8274398-36240207362500/AnsiballZ_vsphere_copy.py", line 114, in <module>
    _ansiballz_main()
  File "/home/user/.ansible/tmp/ansible-tmp-1561111440.8274398-36240207362500/AnsiballZ_vsphere_copy.py", line 106, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/user/.ansible/tmp/ansible-tmp-1561111440.8274398-36240207362500/AnsiballZ_vsphere_copy.py", line 49, in invoke_module
    imp.load_module('__main__', mod, module, MOD_DESC)
  File "/tmp/ansible_vsphere_copy_payload_Ad8BJj/__main__.py", line 200, in <module>
  File "/tmp/ansible_vsphere_copy_payload_Ad8BJj/__main__.py", line 179, in main
IndexError: tuple index out of range

after:

The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_vsphere_copy_payload_v0wHic/__main__.py", line 179, in main
    if isinstance(e[0], int):
IndexError: tuple index out of range

fatal: [router1.private]: FAILED! => {
    "changed": false,
    "errno": -1,
    "invocation": {
        "module_args": {
            "datacenter": "ha-datacenter",
            "datastore": "live",
            "dest": "cfg/router1.private.iso",
            "host": "10.1.1.10",
            "hostname": "10.1.1.10",
            "login": "ansible",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "path": "cfg/router1.private.iso",
            "src": "/tmp/router1.private/router1.private.iso",
            "timeout": 60,
            "username": "ansible",
            "validate_certs": false
        }
    },
    "msg": "HTTP Error 500: Internal Server Error",
    "reason": "HTTP Error 500: Internal Server Error",
    "status": null,
    "url": "https://10.1.1.10/folder/cfg/router1.private.iso?dcPath=ha-datacenter&dsName=live"
}

[lijok]

This most likely requires a proper fix, as the error should be caught as part of https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/vmware/vsphere_copy.py#L193-L203

[lijok]

consecutive reruns of this module after a failure tend to result in the following

The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_vsphere_copy_payload_UIs8Yx/__main__.py", line 168, in main
    force_basic_auth=True)
  File "/tmp/ansible_vsphere_copy_payload_UIs8Yx/ansible_vsphere_copy_payload.zip/ansible/module_utils/urls.py", line 1257, in open_url
    use_gssapi=use_gssapi, unix_socket=unix_socket)
  File "/tmp/ansible_vsphere_copy_payload_UIs8Yx/ansible_vsphere_copy_payload.zip/ansible/module_utils/urls.py", line 1163, in open
    r = urllib_request.urlopen(*urlopen_args)
  File "/usr/lib64/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 429, in open
    response = self._open(req, data)
  File "/usr/lib64/python2.7/urllib2.py", line 447, in _open
    '_open', req)
  File "/usr/lib64/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/tmp/ansible_vsphere_copy_payload_UIs8Yx/ansible_vsphere_copy_payload.zip/ansible/module_utils/urls.py", line 374, in https_open
    return self.do_open(self._build_https_connection, req)
  File "/usr/lib64/python2.7/urllib2.py", line 1200, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 32] Broken pipe>

which i would understand is what is being referenced in https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/vmware/vsphere_copy.py#L197 ?

[ansibot]

cc @Akasurde @Tomorrow9 @dagwieers @dav1x @goneri @lparkes @pgbidkar @warthog9
click here for bot help

[dagwieers]

I warned for this, the catchall Exception above is the wrong approach.

[Akasurde]

@dagwieers I am totally agree with you. @lijok Could you please do the needful, thanks.

[gundalow]

Looked at this during PR review day

• lijok has deleted their fork of Ansible
• Fix needs work (given VMware: vsphere_copy IndexError: tuple index out of range #58170 (review))

I propose that this be closed and remaining work is tracked via issue #58168