Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ce_static_route: fix some bugs. #58251

Merged
merged 7 commits into from Jun 28, 2019
Merged

ce_static_route: fix some bugs. #58251

merged 7 commits into from Jun 28, 2019

Conversation

yuandongx
Copy link
Contributor

SUMMARY

ce_static_route: fix some bugs.
See ADDITIONAL INFORMATION.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_static_route.py

ADDITIONAL INFORMATION
  1. The IPv6 binary system has a length of 128 bits and is grouped by 16 bits. Each group is separated by a colon ":" and can be divided into 8 groups, each group being represented by 4 hexadecimal.
    You can use a double colon "::" to represent a group of 0 or more consecutive 0s, but only once.
  2. Divisible compatible with Python2 and Python3.
  3. To find all elements, Data root node that is taged 'data' should be removed.

@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2019

@xuxiaowei0512 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. python3 support:community This issue/PR relates to code supported by the Ansible community. labels Jun 23, 2019
@yuandongx
Copy link
Contributor Author

bot_status

@yuandongx yuandongx closed this Jun 23, 2019
@yuandongx yuandongx reopened this Jun 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2019

Components

lib/ansible/modules/network/cloudengine/ce_static_route.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: xuxiaowei0512
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: True
merge_commits: [u'https://github.com/ansible/ansible/commit/c763a46e55fb7d61e1ebc328a4575e6831df32d5']
too many files or commits: False
mergeable_state: unstable
shippable_status: pending
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

@yuandongx
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @niuzhenguo @zengchen1024 @zhongjun2
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2019

Components

lib/ansible/modules/network/cloudengine/ce_static_route.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): xuxiaowei0512
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 23, 2019
@yuandongxx
Copy link
Contributor

shipit

@ansibot ansibot removed the community_review In order to be merged, this PR must follow the community review workflow. label Jun 28, 2019
@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_triage Needs a first human triage before being processed. labels Jun 28, 2019
@ansibot ansibot merged commit bb33c92 into ansible:devel Jun 28, 2019
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@agowa
ce_static_route: fix some bugs. (ansible#58251)
0bbc262 
* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.
abadger pushed a commit that referenced this pull request Jul 15, 2019
@yuandongx @abadger
Backport/2.8/58251 ce_static_route: fix some bugs. (#58251) (#58565)
4d9542a 
* ce_static_route:  fix some bugs. (#58251)

* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.

(cherry picked from commit bb33c92)

* add a changelog fragment to PR 58565.

* Update 58565-update-ce_static_route-to-fix-a-bug.yml
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@yuandongx yuandongx deleted the dev/update/ce_static_route branch September 26, 2019 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. python3 shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuandongx @ansibot @yuandongxx