Fix "no matches for wildcard" error in env-setup.fish script.

[ElijahLynn]

SUMMARY

Fix "no matches for wildcard" error in env-setup.fish script. See fish-shell/fish-shell#5960

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

hacking/env-setup.fish

ADDITIONAL INFORMATION

Before

> ❯ source ./hacking/env-setup.fish
./hacking/env-setup.fish (line 69): No matches for wildcard “$PREFIX_PYTHONPATH/ansible*.egg-info”. See `help expand`.
    if test -e $PREFIX_PYTHONPATH/ansible*.egg-info
               ^
in function “gen_egg_info”
        called on line 88 of file ./hacking/env-setup.fish
from sourcing file ./hacking/env-setup.fish
        called on standard input

After

> ❯ source ./hacking/env-setup.fish                                      
> Appending PYTHONPATH                                                   
> running egg_info 
...

[faho]

Ummm... this bit won't work, because the "*" is quoted?

[ElijahLynn]

Hrm, I tested it locally and it worked nicely. Are you saying I should quote it?

[faho]

Noooo.

The rm -rf argument should not be quoted, is what I'm saying.

[faho]

rm -rf "$PREFIX_PYTHONPATH/ansible*.egg-info" does not work because of the quotes.

When you say "it worked nicely", what you mean is presumably that you're not seeing the error anymore. But that's probably just because no file matches, so the rm is never executed.

[ElijahLynn]

Oh, I see now. I was still looking at the if line, doh. I'll fix and test locally.

[ElijahLynn]

Nice catch! Fixed, tested, pushed!

[samdoran]

@ElijahLynn @faho Thank you for this fix. I could not figured out a way to get rid of this error when I wrote that line. Much appreciated, and I learned something. 😄