Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to the Infoblox NIOS modules #58521

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@krisvasudevan
Copy link
Contributor

commented Jun 28, 2019

SUMMARY

Fixes #56856
Fixes #58378

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nios_ptr_record
nios_srv_record

ADDITIONAL INFORMATION

krisvasudevan added some commits Jun 28, 2019

@krisvasudevan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

@ansibot ansibot added needs_revision and removed core_review labels Jun 28, 2019

@mattclay mattclay added the ci_verified label Jul 1, 2019

@ansibot ansibot removed the needs_triage label Jul 1, 2019

@justjais

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@krisvasudevan u'll need to update integration tests as you have made view as required parameter, so update the respective integration tests for the shippable tests to pass, rest code changes LGTM.

@ansibot ansibot added the stale_ci label Jul 10, 2019

@krisvasudevan

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@justjais I've updated both the unit tests and the integration tests.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/net_tools/nios/test_nios_ptr_record.py:183:161: E501 line too long (172 > 160 characters)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/net_tools/nios/test_nios_ptr_record.py:183:161: E501 line too long (172 > 160 characters)

click here for bot help

@ansibot ansibot added the ci_verified label Jul 11, 2019

@ansibot ansibot removed the ci_verified label Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.