Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes to the Infoblox NIOS modules #58521

Merged
merged 5 commits into from Sep 17, 2019
Merged

Bug fixes to the Infoblox NIOS modules #58521

merged 5 commits into from Sep 17, 2019

Conversation

krisvasudevan
Copy link
Contributor

SUMMARY

Fixes #56856
Fixes #58378

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nios_ptr_record
nios_srv_record

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 28, 2019

cc @NilashishC @Qalthos @clementtrebuchet @danielmellado @ganeshrn @justjais @rcarrillocruz @sganesh-infoblox @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category small_patch support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 28, 2019
@krisvasudevan
Copy link
Contributor Author

@sgiri

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 28, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jul 1, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 1, 2019
@justjais
Copy link
Contributor

@krisvasudevan u'll need to update integration tests as you have made view as required parameter, so update the respective integration tests for the shippable tests to pass, rest code changes LGTM.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2019
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 11, 2019
@krisvasudevan
Copy link
Contributor Author

@justjais I've updated both the unit tests and the integration tests.

@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/net_tools/nios/test_nios_ptr_record.py:183:161: E501 line too long (172 > 160 characters)

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/net_tools/nios/test_nios_ptr_record.py:183:161: E501 line too long (172 > 160 characters)

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jul 11, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 11, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 19, 2019
@sgiri
Copy link

sgiri commented Aug 1, 2019 via email

@justjais
Copy link
Contributor

justjais commented Aug 1, 2019

@sgiri plz ignore the tag, as u were tagged by mistake as tag was meant for @S-GIRI.

@justjais justjais merged commit 8bc397c into ansible:devel Sep 17, 2019
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@krisvasudevan @anas-shami
Bug fixes to the Infoblox NIOS modules (ansible#58521)
9ad8c53 
* Update nios_ptr_record to fix bug ansible#58378

* Update to api.py to fix bug ansible#58378 and ansible#56856

* Update test_nios_ptr_record.py to fix bug ansible#58378

* Update nios_ptr_record_idempotence.yml to fix bug ansible#58378

*  Update test_nios_ptr_record.py to fix bug ansible#58378
@ansible ansible locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS module This issue/PR relates to a module. net_tools Net-tools category networking Network category small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
5 participants
@krisvasudevan @ansibot @justjais @sgiri @mattclay