Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new network platform (qnos) #58809

Closed
wants to merge 10 commits into from
Closed

add new network platform (qnos) #58809

wants to merge 10 commits into from
+980 −0

Conversation

Quanta-Switch
Copy link

SUMMARY

Add new network platform for network_cli
ansible_network_os=qnos

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/plugins/action/qnos.py
lib/ansible/plugins/cliconf/qnos.py
lib/ansible/plugins/terminal/qnos.py
And test cases for cli_command
test/integration/targets/qnos_config/tests/cli_config

ADDITIONAL INFORMATION

Set the following in the inventory

ansible_network_os=qnos
ansible_connection=network_cli

@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

cc @acozine @samccann
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

The test ansible-test sanity --test action-plugin-docs [explain] failed with 1 error:

lib/ansible/plugins/action/qnos.py:0:0: action plugin has no matching module to provide documentation

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. needs_triage Needs a first human triage before being processed. labels Jul 8, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jul 8, 2019
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 9, 2019
samccann
samccann suggested changes Jul 9, 2019
View reviewed changes
docs/docsite/rst/network/user_guide/platform_qnos.rst Outdated Show resolved Hide resolved
docs/docsite/rst/network/user_guide/platform_qnos.rst Outdated Show resolved Hide resolved
lib/ansible/plugins/cliconf/qnos.py Show resolved Hide resolved
lib/ansible/plugins/cliconf/qnos.py Outdated Show resolved Hide resolved
@Quanta-Switch
Copy link
Author

Trigger shippable test by closing this PR and opennig it later.

@Quanta-Switch Quanta-Switch reopened this Jul 10, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jul 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

@chiuhsiapeng This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed stale_review Updates were made after the last review and the last review is more than 7 days old. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 23, 2019
@Quanta-Switch
Copy link
Author

Try another PR

@ansible ansible locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn left review comments

@samccann samccann samccann requested changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Quanta-Switch @ansibot @ganeshrn @samccann