Postgresql modules: tidying up of CI tests

test/integration/targets/postgresql/tasks/pg_authid_not_readable.yml

@@ -1,6 +1,6 @@
 - name: "Admin user is allowed to access pg_authid relation: password comparison will succeed, password won't be updated"
   become_user: "{{ pg_user }}"
-  become: True
+  become: yes
   postgresql_user:
     name: "{{ db_user1 }}"
     encrypted: 'yes'
@@ -21,7 +21,7 @@
   shell: 'psql -c "select * from pg_authid;" {{ db_name }} {{ db_user1 }}'
   environment:
     PGPASSWORD: '{{ db_password }}'
-  ignore_errors: True
+  ignore_errors: yes
   register: pg_authid
 
 - assert:
@@ -31,7 +31,7 @@
 
 - name: "Normal user isn't allowed to access pg_authid relation: password comparison will fail, password will be updated"
   become_user: "{{ pg_user }}"
-  become: True
+  become: yes
   postgresql_user:
     name: "{{ db_user1 }}"
     encrypted: 'yes'

test/integration/targets/postgresql/tasks/postgresql_copy.yml

@@ -8,7 +8,7 @@
     data_file_csv: /tmp/data.csv
     task_parameters: &task_parameters
       become_user: '{{ pg_user }}'
-      become: True
+      become: yes
       register: result
     pg_parameters: &pg_parameters
       login_user: '{{ pg_user }}'
@@ -55,7 +55,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   # check that nothing changed after the previous step:
   - name: postgresql_copy - check that data_file_txt doesn't exist
@@ -79,7 +79,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   # check that nothing changed after the previous step:
   - name: postgresql_copy - check that test table continue to have one row
@@ -116,7 +116,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["COPY \"{{ test_table }}\" TO '{{ data_file_txt }}'"]
       - result.src == '{{ test_table }}'
       - result.dst == '{{ data_file_txt }}'
@@ -145,7 +145,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["COPY \"{{ test_table }}\" (id,name) TO '{{ data_file_csv }}' (format csv)"]
       - result.src == '{{ test_table }}'
       - result.dst == '{{ data_file_csv }}'
@@ -173,7 +173,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["COPY \"{{ test_table }}\" (id,name) FROM '{{ data_file_csv }}' (format csv)"]
       - result.dst == '{{ test_table }}'
       - result.src == '{{ data_file_csv }}'
@@ -202,7 +202,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["COPY \"{{ test_table }}\" (id, name) TO PROGRAM '/bin/true' (delimiter '|')"]
       - result.src == '{{ test_table }}'
       - result.dst == '/bin/true'
@@ -221,7 +221,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["COPY \"{{ test_table }}\" (id, name) FROM PROGRAM 'echo 1,first' (delimiter ',')"]
       - result.dst == '{{ test_table }}'
       - result.src == 'echo 1,first'

test/integration/targets/postgresql/tasks/postgresql_db.yml

@@ -8,7 +8,7 @@
     db_name: acme
     block_parameters: &block_parameters
       become_user: "{{ pg_user }}"
-      become: True
+      become: yes
     task_parameters: &task_parameters
       register: result
     pg_parameters: &pg_parameters
@@ -37,7 +37,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_db_tablespace - Check actual DB tablespace, rowcount must be 0 because actually nothing changed
     <<: *task_parameters
@@ -64,7 +64,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_db_tablespace - Check actual DB tablespace, rowcount must be 1
     <<: *task_parameters
@@ -91,7 +91,7 @@
 
   - assert:
       that:
-      - result.changed == false
+      - result is not changed
 
   # Try to change tablespace in check_mode:
   - name: postgresql_db_tablespace - Change tablespace in check_mode
@@ -105,7 +105,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_db_tablespace - Check actual DB tablespace, rowcount must be 1 because actually nothing changed
     <<: *task_parameters
@@ -132,7 +132,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_db_tablespace - Check actual DB tablespace, rowcount must be 1
     <<: *task_parameters

test/integration/targets/postgresql/tasks/postgresql_ext.yml

@@ -43,7 +43,7 @@
 
 - assert:
     that:
-    - result.changed == true
+    - result is changed
     - result.queries == []
 
 # Check that extension doesn't exist after the previous step, rowcount must be 0
@@ -73,7 +73,7 @@
 
 - assert:
     that:
-    - result.changed == true
+    - result is changed
     - result.queries == ['CREATE EXTENSION "postgis"']
 
 # Check that extension exists after the previous step, rowcount must be 1
@@ -103,7 +103,7 @@
 
 - assert:
     that:
-    - result.changed == true
+    - result is changed
     - result.queries == ['DROP EXTENSION "postgis"']
 
 # Check that extension doesn't exist after the previous step, rowcount must be 0
@@ -133,7 +133,7 @@
 
 - assert:
     that:
-    - result.changed == true
+    - result is changed
     - result.queries == ['CREATE EXTENSION "postgis" WITH SCHEMA "schema1"']
 
 # Check that extension exists after the previous step, rowcount must be 1
@@ -174,7 +174,7 @@
 
 - assert:
     that:
-    - result.changed == true
+    - result is changed
     - result.queries == ['DROP EXTENSION "postgis" CASCADE']
 
 # Check that extension doesn't exist after the previous step, rowcount must be 0
@@ -206,7 +206,7 @@
 
 - assert:
     that:
-    - result.changed == true
+    - result is changed
     - result.queries == ['CREATE EXTENSION "postgis" CASCADE"']
   when: postgres_version_resp.stdout is version('9.6', '<=')
 

test/integration/targets/postgresql/tasks/postgresql_ext_version_opt.yml

@@ -7,7 +7,7 @@
     test_schema: schema1
     task_parameters: &task_parameters
       become_user: '{{ pg_user }}'
-      become: True
+      become: yes
       register: result
     pg_parameters: &pg_parameters
       login_user: '{{ pg_user }}'
@@ -28,12 +28,12 @@
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 1.0
+      version: '1.0'
     check_mode: yes
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_ext_version - check that nothing was actually changed
     <<: *task_parameters
@@ -51,11 +51,11 @@
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 1.0
+      version: '1.0'
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["CREATE EXTENSION \"{{ test_ext }}\" WITH SCHEMA \"{{ test_schema }}\" VERSION '1.0'"]
 
   - name: postgresql_ext_version - check
@@ -74,12 +74,12 @@
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 1.0
+      version: '1.0'
     check_mode: yes
 
   - assert:
       that:
-      - result.changed == false
+      - result is not changed
 
   - name: postgresql_ext_version - check
     <<: *task_parameters
@@ -97,11 +97,11 @@
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 1.0
+      version: '1.0'
 
   - assert:
       that:
-      - result.changed == false
+      - result is not changed
 
   - name: postgresql_ext_version - check
     <<: *task_parameters
@@ -119,12 +119,12 @@
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 2.0
+      version: '2.0'
     check_mode: yes
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_ext_version - check, the version must be 1.0
     <<: *task_parameters
@@ -142,11 +142,11 @@
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 2.0
+      version: '2.0'
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["ALTER EXTENSION \"{{ test_ext }}\" UPDATE TO '2.0'"]
 
   - name: postgresql_ext_version - check, the version must be 2.0
@@ -168,7 +168,7 @@
 
   - assert:
       that:
-      - result.changed == false
+      - result is not changed
 
   - name: postgresql_ext_version - check, the version must be 2.0
     <<: *task_parameters
@@ -190,7 +190,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["ALTER EXTENSION \"{{ test_ext }}\" UPDATE TO '3.0'"]
 
   - name: postgresql_ext_version - check
@@ -213,15 +213,15 @@
 
   - assert:
       that:
-      - result.changed == false
+      - result is not changed
 
   - name: postgresql_ext_version - try to downgrade the extension version, must fail
     <<: *task_parameters
     postgresql_ext:
       <<: *pg_parameters
       name: "{{ test_ext }}"
       schema: "{{ test_schema }}"
-      version: 1.0
+      version: '1.0'
     ignore_errors: yes
 
   - assert:
@@ -238,7 +238,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_ext_version - check that extension exists
     <<: *task_parameters
@@ -259,7 +259,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
 
   - name: postgresql_ext_version - check that extension doesn't exist after the prev step
     <<: *task_parameters
@@ -280,7 +280,7 @@
 
   - assert:
       that:
-      - result.changed == false
+      - result is not changed
 
   - name: postgresql_ext_version - create the extension without passing version
     <<: *task_parameters
@@ -290,7 +290,7 @@
 
   - assert:
       that:
-      - result.changed == true
+      - result is changed
       - result.queries == ["CREATE EXTENSION \"{{ test_ext }}\""]
 
   - name: postgresql_ext_version - check