Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipaddr: add an option to return peer of a point-to-point link #59144

Merged
merged 2 commits into from
Nov 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/docsite/rst/user_guide/playbooks_filters_ipaddr.rst
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,13 @@ To find the next nth usable IP address within a range, use ``next_nth_usable``::

In this example, ``next_nth_usable`` returns the second usable IP address for the given IP range.

To find the peer IP address for a point to point link, use ``peer``::

# {{ '192.168.122.1/31' | ipaddr('peer') }}
192.168.122.0
# {{ '192.168.122.1/30' | ipaddr('peer') }}
192.168.122.2

samccann marked this conversation as resolved.
Show resolved Hide resolved

IP Math
^^^^^^^
Expand Down
17 changes: 17 additions & 0 deletions lib/ansible/plugins/filter/ipaddr.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,21 @@ def _next_usable_query(v, vtype):
return str(netaddr.IPAddress(int(v.ip) + 1))


def _peer_query(v, vtype):
if vtype == 'address':
raise errors.AnsibleFilterError("Not a network address")
elif vtype == 'network':
if v.size == 2:
return str(netaddr.IPAddress(int(v.ip) ^ 1))
if v.size == 4:
if int(v.ip) % 4 == 0:
raise errors.AnsibleFilterError("Network address of /30 has no peer")
if int(v.ip) % 4 == 3:
raise errors.AnsibleFilterError("Broadcast address of /30 has no peer")
return str(netaddr.IPAddress(int(v.ip) ^ 3))
raise errors.AnsibleFilterError("Not a point-to-point network")


def _prefix_query(v):
return int(v.prefixlen)

Expand Down Expand Up @@ -463,6 +478,7 @@ def ipaddr(value, query='', version=False, alias='ipaddr'):
'lo': ('value',),
'multicast': ('value',),
'next_usable': ('vtype',),
'peer': ('vtype',),
'previous_usable': ('vtype',),
'private': ('value',),
'public': ('value',),
Expand Down Expand Up @@ -507,6 +523,7 @@ def ipaddr(value, query='', version=False, alias='ipaddr'):
'network/prefix': _subnet_query,
'network_netmask': _network_netmask_query,
'network_wildcard': _network_wildcard_query,
'peer': _peer_query,
'prefix': _prefix_query,
'previous_usable': _previous_usable_query,
'private': _private_query,
Expand Down
25 changes: 25 additions & 0 deletions test/units/plugins/filter/test_ipaddr.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,31 @@ def test_next_usable(self):
address = '1.12.1.254/24'
self.assertEqual(ipaddr(address, 'next_usable'), None)

def test_peer(self):
address = '1.12.1.0/31'
self.assertEqual(ipaddr(address, 'peer'), '1.12.1.1')
address = '1.12.1.1/31'
self.assertEqual(ipaddr(address, 'peer'), '1.12.1.0')
address = '1.12.1.1/30'
self.assertEqual(ipaddr(address, 'peer'), '1.12.1.2')
address = '1.12.1.2/30'
self.assertEqual(ipaddr(address, 'peer'), '1.12.1.1')
with self.assertRaises(AnsibleFilterError):
address = '1.12.1.34'
ipaddr(address, 'peer')
with self.assertRaises(AnsibleFilterError):
address = '1.12.1.33/29'
ipaddr(address, 'peer')
with self.assertRaises(AnsibleFilterError):
address = '1.12.1.32/30'
ipaddr(address, 'peer')
with self.assertRaises(AnsibleFilterError):
address = '1.12.1.35/30'
ipaddr(address, 'peer')
with self.assertRaises(AnsibleFilterError):
address = '1.12.1.34/32'
ipaddr(address, 'peer')

def test_previous_usable(self):
address = '1.12.1.0/24'
self.assertEqual(ipaddr(address, 'previous_usable'), None)
Expand Down