Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dns info to gather facts #59145

Merged
merged 3 commits into from Jul 19, 2019
Merged

add dns info to gather facts #59145

merged 3 commits into from Jul 19, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Add DNS info to gather facts.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_gather_facts.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 16, 2019

cc @amit0701 @dprts @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:certified This issue/PR relates to certified code. labels Jul 16, 2019
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 16, 2019
@thedoubl3j thedoubl3j self-assigned this Jul 16, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 16, 2019
lonico
lonico approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Jul 16, 2019
thedoubl3j
thedoubl3j approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change, lgtm. shipit

@thedoubl3j thedoubl3j merged commit f8c278e into ansible:devel Jul 19, 2019
@ansible ansible locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees

@thedoubl3j thedoubl3j

Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @lonico @thedoubl3j